Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Compare card of subgroup to card of group #5347

Closed
wants to merge 5 commits into from

Conversation

BoltonBailey
Copy link
Collaborator

@BoltonBailey BoltonBailey commented Jun 21, 2023

Includes new lemmas, one that shows that the cardinality of a subgroup is at most the cardinality of the ambient group, and others which shows that the cardinality of the top group is equal to that of the ambient group, and that in fact this is iff.

Co-authored-by: Floris van Doorn


Open in Gitpod

@BoltonBailey BoltonBailey added the WIP Work in progress label Jun 21, 2023
@BoltonBailey
Copy link
Collaborator Author

Maintainers, let me know if we are not accepting PRs to ported files yet

@BoltonBailey BoltonBailey added awaiting-CI and removed WIP Work in progress labels Jun 21, 2023
@j-loreaux j-loreaux changed the title feat(GroupTheory/Subgroup/Finite): Compare card to group feat: Compare card of subgroup to card of group Jun 21, 2023
@j-loreaux
Copy link
Collaborator

j-loreaux commented Jun 21, 2023

new results are fine to add (maybe not new instances, depending on the situation), but refactors will probably be forced to wait until after the port. Also, just FYI, we no longer specify the filename in the PR title.

@BoltonBailey
Copy link
Collaborator Author

Ok cool no refactors here, just new lemmas

@BoltonBailey BoltonBailey added the awaiting-review The author would like community review of the PR label Jun 21, 2023
@semorrison semorrison added the new-feature Add features not present in Mathlib 3 label Jun 23, 2023
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks: please apply the suggestion and then feel free to merge.

bors d+

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jul 1, 2023
Co-authored-by: Oliver Nash <github@olivernash.org>
@BoltonBailey
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jul 3, 2023
Includes new lemmas, one that shows that the cardinality of a subgroup is at most the cardinality of the ambient group, and others which shows that the cardinality of the top group is equal to that of the ambient group, and that in fact this is iff.

Co-authored-by: Floris van Doorn
@bors
Copy link

bors bot commented Jul 3, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Compare card of subgroup to card of group [Merged by Bors] - feat: Compare card of subgroup to card of group Jul 3, 2023
@bors bors bot closed this Jul 3, 2023
@bors bors bot deleted the BoltonBailey/subgroup-card branch July 3, 2023 02:58
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
Includes new lemmas, one that shows that the cardinality of a subgroup is at most the cardinality of the ambient group, and others which shows that the cardinality of the top group is equal to that of the ambient group, and that in fact this is iff.

Co-authored-by: Floris van Doorn
semorrison pushed a commit that referenced this pull request Aug 14, 2023
Includes new lemmas, one that shows that the cardinality of a subgroup is at most the cardinality of the ambient group, and others which shows that the cardinality of the top group is equal to that of the ambient group, and that in fact this is iff.

Co-authored-by: Floris van Doorn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated new-feature Add features not present in Mathlib 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants