Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port NumberTheory.NumberField.Units #5359

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: port NumberTheory.NumberField.Units #5359

wants to merge 4 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

Open in Gitpod

@Parcly-Taxel
feat: port NumberTheory.NumberField.Units
8b80e8e
@Parcly-Taxel
Initial file copy from mathport
ea3484a
@Parcly-Taxel
automated fixes
e3a31da 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Parcly-Taxel
Fix errors
9d20ccc
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. awaiting-CI labels Jun 22, 2023
@RemyDegenne
Copy link
Contributor

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 22, 2023
bors bot pushed a commit that referenced this pull request Jun 22, 2023
@Parcly-Taxel
feat: port NumberTheory.NumberField.Units (#5359)
81c3108
@bors
Copy link

bors bot commented Jun 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port NumberTheory.NumberField.Units [Merged by Bors] - feat: port NumberTheory.NumberField.Units Jun 22, 2023
@bors bors bot closed this Jun 22, 2023
@bors bors bot deleted the port/NumberTheory.NumberField.Units branch June 22, 2023 06:48
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
@Parcly-Taxel @alexkeizer
feat: port NumberTheory.NumberField.Units (#5359)
9d628af
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@Parcly-Taxel @semorrison
feat: port NumberTheory.NumberField.Units (#5359)
811485e
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@Parcly-Taxel @semorrison
feat: port NumberTheory.NumberField.Units (#5359)
aa9a688
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@Parcly-Taxel @semorrison
feat: port NumberTheory.NumberField.Units (#5359)
e58df26
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
@Parcly-Taxel @kbuzzard
feat: port NumberTheory.NumberField.Units (#5359)
9a04ec9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Parcly-Taxel @RemyDegenne