Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: count_heartbeats in command #5365

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: count_heartbeats in command #5365

wants to merge 4 commits into from

Conversation

semorrison
Copy link
Contributor

Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR t-meta Tactics, attributes or user commands awaiting-CI labels Jun 22, 2023
@semorrison semorrison requested a review from urkud June 22, 2023 05:10
fpvandoorn
fpvandoorn reviewed Jun 22, 2023
View reviewed changes
Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did you check that it works, and that the suggestion replaces the right thing?

bors d+

Mathlib/Util/CountHeartbeats.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jun 22, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jun 22, 2023
@semorrison
Copy link
Contributor Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jun 23, 2023
bors bot pushed a commit that referenced this pull request Jun 23, 2023
@semorrison
feat: count_heartbeats in command (#5365)
489a049 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Jun 23, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: count_heartbeats in command [Merged by Bors] - feat: count_heartbeats in command Jun 23, 2023
@bors bors bot closed this Jun 23, 2023
@bors bors bot deleted the count_heartbeats branch June 23, 2023 01:26
semorrison added a commit that referenced this pull request Jun 23, 2023
@semorrison
feat: count_heartbeats in command (#5365)
77ebb31 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
semorrison added a commit that referenced this pull request Jun 23, 2023
@semorrison
feat: count_heartbeats in command (#5365)
e43b50e 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
semorrison added a commit that referenced this pull request Jun 25, 2023
@semorrison
feat: count_heartbeats in command (#5365)
f27188e 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
@semorrison @kbuzzard
feat: count_heartbeats in command (#5365)
1847579 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpvandoorn fpvandoorn fpvandoorn left review comments

@urkud urkud Awaiting requested review from urkud

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @fpvandoorn