Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: forward-port mathlib#19204 #5369

Closed
wants to merge 4 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Jun 22, 2023


Open in Gitpod

@xroblot xroblot added WIP Work in progress mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Jun 22, 2023
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check that the names in the various comments are the Lean4 names, otherwise LGTM, thanks!

bors d+

Mathlib/Algebra/Invertible.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jun 22, 2023

✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@xroblot xroblot added awaiting-CI and removed WIP Work in progress labels Jun 22, 2023
xroblot and others added 2 commits June 22, 2023 11:43
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@eric-wieser
Copy link
Member

bors merge

Thanks!

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jun 22, 2023
bors bot pushed a commit that referenced this pull request Jun 22, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Jun 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: forward-port mathlib#19204 [Merged by Bors] - chore: forward-port mathlib#19204 Jun 22, 2023
@bors bors bot closed this Jun 22, 2023
@bors bors bot deleted the forward-port-19204 branch June 22, 2023 11:44
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
semorrison pushed a commit that referenced this pull request Jun 23, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
semorrison pushed a commit that referenced this pull request Jun 23, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
semorrison pushed a commit that referenced this pull request Jun 25, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants