Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/finset/pointwise): |s| ∣ |s * t| #5385

Closed
wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 22, 2023

Forward-port leanprover-community/mathlib#18663

Also add a missing lemma.


@YaelDillies In the added lemma, what is the canonical way to write the assumption? Use smul (as I did) or some Finset.image?

Open in Gitpod

@urkud urkud requested a review from YaelDillies June 22, 2023 13:45
@urkud urkud added awaiting-review The author would like community review of the PR mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Jun 22, 2023
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The canonical way is to use as you did. I will let you decide whether the lemma is actually missing or not.

maintainer merge

distinct!), then the size of `t` divides the size of `s + t`."]
theorem card_dvd_card_mul_right {s t : Finset α} :
((· • t) '' (s : Set α)).PairwiseDisjoint id → t.card ∣ (s * t).card :=
card_dvd_card_image₂_right fun _ _ => mul_right_injective _
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
card_dvd_card_image₂_right fun _ _ => mul_right_injective _
card_dvd_card_smul_right

I think this is why I didn't make it a lemma.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already on the queue... I see that these two lemmas are defeq but we don't drop mul_assoc because we have smul_assoc etc.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arf, we really need maintainer delegate ☹️

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

1 similar comment
@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 22, 2023
bors bot pushed a commit that referenced this pull request Jun 22, 2023
@bors
Copy link

bors bot commented Jun 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(data/finset/pointwise): |s| ∣ |s * t| [Merged by Bors] - feat(data/finset/pointwise): |s| ∣ |s * t| Jun 22, 2023
@bors bors bot closed this Jun 22, 2023
@bors bors bot deleted the forward-port-18663 branch June 22, 2023 16:17
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
semorrison pushed a commit that referenced this pull request Jun 23, 2023
semorrison pushed a commit that referenced this pull request Jun 23, 2023
semorrison pushed a commit that referenced this pull request Jun 25, 2023
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants