-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(data/finset/pointwise): |s| ∣ |s * t| #5385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The canonical way is to use •
as you did. I will let you decide whether the lemma is actually missing or not.
maintainer merge
distinct!), then the size of `t` divides the size of `s + t`."] | ||
theorem card_dvd_card_mul_right {s t : Finset α} : | ||
((· • t) '' (s : Set α)).PairwiseDisjoint id → t.card ∣ (s * t).card := | ||
card_dvd_card_image₂_right fun _ _ => mul_right_injective _ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
card_dvd_card_image₂_right fun _ _ => mul_right_injective _ | |
card_dvd_card_smul_right |
I think this is why I didn't make it a lemma.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already on the queue... I see that these two lemmas are defeq but we don't drop mul_assoc
because we have smul_assoc
etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arf, we really need maintainer delegate
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
1 similar comment
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
bors merge |
Forward-port leanprover-community/mathlib#18663 Also add a missing lemma.
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Forward-port leanprover-community/mathlib#18663 Also add a missing lemma.
Forward-port leanprover-community/mathlib#18663 Also add a missing lemma.
Forward-port leanprover-community/mathlib#18663 Also add a missing lemma.
Forward-port leanprover-community/mathlib#18663 Also add a missing lemma.
Forward-port leanprover-community/mathlib#18663 Also add a missing lemma.
Forward-port leanprover-community/mathlib#18663
Also add a missing lemma.
@YaelDillies In the added lemma, what is the canonical way to write the assumption? Use
smul
(as I did) or someFinset.image
?