Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Analysis.Calculus.BumpFunctionFindim #5389

Closed

Conversation

Ruben-VandeVelde
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde commented Jun 22, 2023


Seems like there may be some leanprover/lean4#2220 trouble.

Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Ruben-VandeVelde Ruben-VandeVelde added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 22, 2023
@Ruben-VandeVelde Ruben-VandeVelde added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jun 22, 2023
@mo271
Copy link
Collaborator

mo271 commented Jun 23, 2023

From my point of view this is good to go. I assume w and y should not be upper case, like they were before?

@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Jun 23, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉 LGTM!

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 23, 2023
bors bot pushed a commit that referenced this pull request Jun 23, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Jun 23, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Analysis.Calculus.BumpFunctionFindim [Merged by Bors] - feat: port Analysis.Calculus.BumpFunctionFindim Jun 23, 2023
@bors bors bot closed this Jun 23, 2023
semorrison pushed a commit that referenced this pull request Jun 25, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
semorrison pushed a commit that referenced this pull request Jun 28, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
@int-y1 int-y1 deleted the port/Analysis.Calculus.BumpFunctionFindim branch July 1, 2023 22:18
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants