fix:NumberTheory/LegendreSymbol/GaussSum fix porting note #5419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
xroblot
added
WIP
|
@Parcly-Taxel Again, please do not modify a PR I am working on and that is not marked |
xroblot
added
awaiting-review
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 26, 2023
This PR incorporates also the changes to `NumberTheory.LegendreSymbol.MulCharacter` discussed [here](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/coercion.20issue.20in.20NumberTheory.2ELegendreSymbol.2EMulCharacter/near/343943344) Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
xroblot
added
awaiting-review
ChrisHughes24
changed the title
|
bors merge |
|
Already running a review |
github-actions
bot
added
ready-to-merge
|
bors r+ |
|
Already running a review |
|
@ChrisHughes24 I think I messed up things when I reopened an already merged PR. I am not sure what needs to be done to fix it. The simplest way is probably to close this PR and reopen a new one with the changes. So I'll do that. |
semorrison
pushed a commit
that referenced
this pull request
Jun 28, 2023
This PR incorporates also the changes to `NumberTheory.LegendreSymbol.MulCharacter` discussed [here](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/coercion.20issue.20in.20NumberTheory.2ELegendreSymbol.2EMulCharacter/near/343943344) Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
kbuzzard
pushed a commit
that referenced
this pull request
Jul 6, 2023
This PR incorporates also the changes to `NumberTheory.LegendreSymbol.MulCharacter` discussed [here](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/coercion.20issue.20in.20NumberTheory.2ELegendreSymbol.2EMulCharacter/near/343943344) Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
This PR incorporates also the changes to `NumberTheory.LegendreSymbol.MulCharacter` discussed [here](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/coercion.20issue.20in.20NumberTheory.2ELegendreSymbol.2EMulCharacter/near/343943344) Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates also the changes toNumberTheory.LegendreSymbol.MulCharacterdiscussed hereThis PR has been reopened because I forgot to write a porting note