Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Geometry.Manifold.VectorBundle.Tangent #5448

Closed
wants to merge 8 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 24, 2023

@urkud urkud added the mathlib-port This is a port of a theory file from mathlib. label Jun 24, 2023
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Jun 24, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@urkud urkud force-pushed the port/Geometry.Manifold.VectorBundle.Tangent branch from c618277 to 79097a5 Compare June 24, 2023 15:37
@urkud urkud added the awaiting-review The author would like community review of the PR label Jun 24, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to return to the simp set in this bit of the library after the port is done.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 24, 2023
@bors
Copy link

bors bot commented Jun 24, 2023

Merge conflict.

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

bors bot pushed a commit that referenced this pull request Jun 24, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Jun 24, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Geometry.Manifold.VectorBundle.Tangent [Merged by Bors] - feat: port Geometry.Manifold.VectorBundle.Tangent Jun 24, 2023
@bors bors bot closed this Jun 24, 2023
@bors bors bot deleted the port/Geometry.Manifold.VectorBundle.Tangent branch June 24, 2023 19:58
semorrison pushed a commit that referenced this pull request Jun 25, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
semorrison pushed a commit that referenced this pull request Jun 28, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
semorrison pushed a commit that referenced this pull request Aug 14, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants