Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Geometry.Manifold.ContMdiffMfderiv #5496

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - feat: port Geometry.Manifold.ContMdiffMfderiv #5496

wants to merge 15 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 26, 2023 •
edited
Loading

@semorrison semorrison added blocked-by-other-PR This PR depends on another PR to Mathlib and removed blocked-by-other-PR This PR depends on another PR to Mathlib labels Jun 26, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 26, 2023
@urkud urkud force-pushed the port/Geometry.Manifold.ContMdiffMfderiv branch from 3d53acf to 9322f70 Compare June 27, 2023 14:37
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 27, 2023
@Ruben-VandeVelde Ruben-VandeVelde added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 28, 2023
@urkud urkud added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jun 28, 2023
@urkud urkud force-pushed the port/Geometry.Manifold.ContMdiffMfderiv branch 2 times, most recently from f6ff7fa to a132471 Compare July 5, 2023 13:55
@urkud urkud removed the help-wanted The author needs attention to resolve issues label Jul 10, 2023
@urkud urkud force-pushed the port/Geometry.Manifold.ContMdiffMfderiv branch from a132471 to 441ebfb Compare July 12, 2023 22:12
@urkud urkud added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. and removed mathlib-port This is a port of a theory file from mathlib. labels Jul 12, 2023
semorrison
semorrison reviewed Jul 13, 2023
View reviewed changes
Mathlib/Geometry/Manifold/ContMDiffMFDeriv.lean
Comment on lines +114 to +115
(extChartAt I (g x₀) (g x)))
x₀ := by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor, but I was confused by the syntax here. Perhaps it would be more readable with x₀ at the end of the previous line?

semorrison
semorrison reviewed Jul 13, 2023
View reviewed changes
Mathlib/Geometry/Manifold/ContMDiffMFDeriv.lean Outdated
Comment on lines 127 to 128
(range I) (extChartAt I (g x₀) (g x)))
x₀ := by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto here

semorrison
semorrison reviewed Jul 13, 2023
View reviewed changes
Mathlib/Geometry/Manifold/ContMDiffMFDeriv.lean Outdated
Comment on lines 236 to 242
(fun p : H × E =>
(f p.fst,
(fderivWithin 𝕜 (writtenInExtChartAt I I' p.fst f) (I.symm ⁻¹' s ∩ range I)
((extChartAt I p.fst) p.fst) :
E →L[𝕜] E')
p.snd))
(Prod.fst ⁻¹' s)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excessive newlines?

@semorrison
Copy link
Contributor

bors d+

@bors
Copy link

bors bot commented Jul 13, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jul 13, 2023
urkud and others added 2 commits July 12, 2023 21:06
@urkud @semorrison
Update Mathlib/Geometry/Manifold/ContMDiffMFDeriv.lean
a1623ca 
Co-authored-by: Scott Morrison <scott@tqft.net>
@urkud @semorrison
Update Mathlib/Geometry/Manifold/ContMDiffMFDeriv.lean
5d64a04 
Co-authored-by: Scott Morrison <scott@tqft.net>
@urkud
Copy link
Member Author

urkud commented Jul 13, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 13, 2023
bors bot pushed a commit that referenced this pull request Jul 13, 2023
@urkud
feat: port Geometry.Manifold.ContMdiffMfderiv (#5496)
625a3a6
@bors
Copy link

bors bot commented Jul 13, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Geometry.Manifold.ContMdiffMfderiv [Merged by Bors] - feat: port Geometry.Manifold.ContMdiffMfderiv Jul 13, 2023
@bors bors bot closed this Jul 13, 2023
@bors bors bot deleted the port/Geometry.Manifold.ContMdiffMfderiv branch July 13, 2023 04:21
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@urkud @semorrison
feat: port Geometry.Manifold.ContMdiffMfderiv (#5496)
1dc3ab3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @semorrison @Ruben-VandeVelde