Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port logic.equiv.defs #550

Closed
wants to merge 36 commits into from
Closed

Conversation

semorrison
Copy link
Contributor

@semorrison semorrison commented Nov 7, 2022

mathlib3 sha: 7951ed37deb3b2923a6f47d9bdcb4d69a8703550

Waiting on the release of nightly-2022-11-17.

@semorrison semorrison added help-wanted The author needs attention to resolve issues WIP Work in progress blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Nov 7, 2022
@semorrison semorrison changed the title feat: port data.equiv.defs feat: port logic.equiv.defs Nov 7, 2022
@Vierkantor
Copy link
Contributor

The last parts of this file depend on data.quot via logic.equiv.defs → tactic.basic → tactic.trunc_cases → data.quot. Otherwise everything builds with not too many hacks or backports. But see also: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/.60simp.60.20failing.20on.20partial.20application.20of.20projections

@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Nov 11, 2022
@digama0 digama0 added the mathlib-port This is a port of a theory file from mathlib. label Nov 13, 2022
@semorrison
Copy link
Contributor Author

And now failing on the issue reported at leanprover/lean4#1829

@Ruben-VandeVelde
Copy link
Collaborator

I merged the nightly-2022-11-17 bump, hope that was alright

@digama0
Copy link
Member

digama0 commented Nov 18, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 18, 2022
mathlib3 sha: 7951ed37deb3b2923a6f47d9bdcb4d69a8703550

~~Waiting on the release of [nightly-2022-11-17](https://github.com/leanprover/lean4-nightly/releases/tag/nightly-2022-11-17).~~

- [x] depends on: #541
- [x] depends on: #559

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: David Wärn <codwarn@gmail.com>
Co-authored-by: Yakov Pechersky <ypechersky@treeline.bio>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link

bors bot commented Nov 18, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port logic.equiv.defs [Merged by Bors] - feat: port logic.equiv.defs Nov 18, 2022
@bors bors bot closed this Nov 18, 2022
@bors bors bot deleted the equiv_defs branch November 18, 2022 00:45
bors bot pushed a commit that referenced this pull request Nov 18, 2022
mathlib3 hash: fd47bdf09e90f553519c712378e651975fe8c829

- [x] depends on: #556 
- [x] depends on: #550 



Co-authored-by: Yakov Pechersky <ypechersky@treeline.bio>
Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: David Wärn <codwarn@gmail.com>
bors bot pushed a commit that referenced this pull request Nov 23, 2022
mathlib SHA: c3019c79074b0619edb4b27553a91b2e82242395 [I think this is right..?]
WIP

- [x] depends on: #550

Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: David Wärn <codwarn@gmail.com>
Co-authored-by: Yakov Pechersky <ypechersky@treeline.bio>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants