Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Analysis.InnerProductSpace.LinearPMap #5523

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - feat: port Analysis.InnerProductSpace.LinearPMap #5523

wants to merge 13 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde commented Jun 27, 2023 •
edited by mcdoll

Ruben-VandeVelde and others added 6 commits June 27, 2023 10:18
@Ruben-VandeVelde
feat: port Analysis.InnerProductSpace.LinearPmap
48863a5
@Ruben-VandeVelde
Initial file copy from mathport
37e1747
@Ruben-VandeVelde
automated fixes
4fba436 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@mcdoll
forward
fb5a278
@Ruben-VandeVelde
Move
f3f2117
@Ruben-VandeVelde
Import
a276997
@Ruben-VandeVelde Ruben-VandeVelde added WIP Work in progress after-port mathlib-port This is a port of a theory file from mathlib. and removed after-port labels Jun 27, 2023
@Ruben-VandeVelde Ruben-VandeVelde added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jun 27, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jun 27, 2023
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Jun 27, 2023
jcommelin
jcommelin approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge it after the dependency has landed in master

bors d+

@bors
Copy link

bors bot commented Jun 27, 2023

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Jun 27, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jun 27, 2023
bors bot pushed a commit that referenced this pull request Jun 27, 2023
@Ruben-VandeVelde @mcdoll
feat: port Analysis.InnerProductSpace.LinearPMap (#5523)
9629646 
Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
@bors
Copy link

bors bot commented Jun 27, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Analysis.InnerProductSpace.LinearPMap [Merged by Bors] - feat: port Analysis.InnerProductSpace.LinearPMap Jun 27, 2023
@bors bors bot closed this Jun 27, 2023
@bors bors bot deleted the port/Analysis.InnerProductSpace.LinearPmap branch June 27, 2023 14:24
semorrison pushed a commit that referenced this pull request Jun 28, 2023
@Ruben-VandeVelde @mcdoll @semorrison
feat: port Analysis.InnerProductSpace.LinearPMap (#5523)
af122d7 
Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
@Ruben-VandeVelde @mcdoll @kbuzzard
feat: port Analysis.InnerProductSpace.LinearPMap (#5523)
23c1bb4 
Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@Ruben-VandeVelde @mcdoll @semorrison
feat: port Analysis.InnerProductSpace.LinearPMap (#5523)
fa5bea2 
Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ruben-VandeVelde @semorrison @jcommelin @mcdoll