[Merged by Bors] - refactor: use junk values in Submodule.toLinearPMap #5529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdoll
added
the
awaiting-review
I'm having trouble getting oleans while reviewing. Perhaps merging master will help.
|
✌️ mcdoll can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
The title of the PR is not very clear. |
mcdoll
changed the title
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
Change the definition of `Submodule.toLinearPMap` to use a junk value in the case that the condition that the subspace defines the graph of a function is not satisfied. In this case we define `Submodule.toLinearPMap` as the zero map. The domain is the same so that the domain does not depend on the graph-condition. Co-authored-by: Oliver Nash <github@olivernash.org>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
semorrison
pushed a commit
that referenced
this pull request
Aug 3, 2023
Change the definition of `Submodule.toLinearPMap` to use a junk value in the case that the condition that the subspace defines the graph of a function is not satisfied. In this case we define `Submodule.toLinearPMap` as the zero map. The domain is the same so that the domain does not depend on the graph-condition. Co-authored-by: Oliver Nash <github@olivernash.org>
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
Change the definition of `Submodule.toLinearPMap` to use a junk value in the case that the condition that the subspace defines the graph of a function is not satisfied. In this case we define `Submodule.toLinearPMap` as the zero map. The domain is the same so that the domain does not depend on the graph-condition. Co-authored-by: Oliver Nash <github@olivernash.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the definition of
Submodule.toLinearPMapto use a junk value in the case that the condition that the subspace defines the graph of a function is not satisfied. In this case we defineSubmodule.toLinearPMapas the zero map. The domain is the same so that the domain does not depend on the graph-condition.the file is not completely ported, but since I wrote the relevant parts not too long ago I am very confident that it is not used in the unported files. I am also fine with waiting until all downstream dependencies are ported.