Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.WittVector.Truncated #5538

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.WittVector.Truncated #5538

wants to merge 8 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

Open in Gitpod

@Parcly-Taxel
feat: port RingTheory.WittVector.Truncated
b5b59fa
@Parcly-Taxel
Initial file copy from mathport
fe3f071
@Parcly-Taxel
automated fixes
5775b63 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Parcly-Taxel
Fix errors
6015c95
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. awaiting-CI labels Jun 28, 2023
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 28, 2023
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 28, 2023
@jcommelin
Copy link
Member

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Jun 28, 2023

✌️ Parcly-Taxel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jun 28, 2023
@Parcly-Taxel
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jun 28, 2023
@Parcly-Taxel
feat: port RingTheory.WittVector.Truncated (#5538)
67895f3
@bors
Copy link

bors bot commented Jun 28, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 28, 2023
@Parcly-Taxel
feat: port RingTheory.WittVector.Truncated (#5538)
abaae3b
@bors
Copy link

bors bot commented Jun 28, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port RingTheory.WittVector.Truncated [Merged by Bors] - feat: port RingTheory.WittVector.Truncated Jun 28, 2023
@bors bors bot closed this Jun 28, 2023
@bors bors bot deleted the port/RingTheory.WittVector.Truncated branch June 28, 2023 11:45
semorrison pushed a commit that referenced this pull request Jun 29, 2023
@Parcly-Taxel @semorrison
feat: port RingTheory.WittVector.Truncated (#5538)
b7ff806
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
@Parcly-Taxel @kbuzzard
feat: port RingTheory.WittVector.Truncated (#5538)
d6d8e98
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@Parcly-Taxel @semorrison
feat: port RingTheory.WittVector.Truncated (#5538)
51c0354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison Awaiting requested review from semorrison

@jcommelin jcommelin Awaiting requested review from jcommelin

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Parcly-Taxel @jcommelin @semorrison