Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port NumberTheory.ModularForms.JacobiTheta.Basic #5547

Closed

Conversation

Parcly-Taxel
Copy link
Collaborator

@Parcly-Taxel Parcly-Taxel commented Jun 28, 2023

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
…Infty' into port/NumberTheory.ModularForms.JacobiTheta.Basic
@Parcly-Taxel Parcly-Taxel added blocked-by-other-PR This PR depends on another PR which is still in the queue. awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. awaiting-CI labels Jun 28, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Jun 28, 2023

✌️ Parcly-Taxel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jun 28, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jun 28, 2023
@semorrison
Copy link
Contributor

@Parcly-Taxel
Copy link
Collaborator Author

bors merge

@bors
Copy link

bors bot commented Jun 28, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port NumberTheory.ModularForms.JacobiTheta.Basic [Merged by Bors] - feat: port NumberTheory.ModularForms.JacobiTheta.Basic Jun 28, 2023
@bors bors bot closed this Jun 28, 2023
@bors bors bot deleted the port/NumberTheory.ModularForms.JacobiTheta.Basic branch June 28, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants