[Merged by Bors] - feat: port number_theory.legendre_symbol.norm_num to Tactic.NormNum.LegendreSymbol #5548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Komyyy
commented
Jun 28, 2023
Komyyy
commented
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
Komyyy
added
WIP
Komyyy
added
awaiting-review
Komyyy
changed the title
semorrison
reviewed
Jun 29, 2023
|
Looks very nice! bors d+ |
|
✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
|
bors r+ |
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
| show (er : Q(ℤ)) × Q(jacobiSymNat 1 $eb = $er) from | ||
| ⟨mkRawIntLit 1, q(jacobiSymNat.one_left $eb)⟩ | ||
| | a => | ||
| match a % 0 with |
There was a problem hiding this comment.
This looks incorrect. I guess it should be a % 2 instead of a % 0.
There was a problem hiding this comment.
Oh, that's wrong, thank you.
I'll create the PR after porting Traversable deriving handler.
kbuzzard
pushed a commit
that referenced
this pull request
Jul 6, 2023
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.