Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port SetTheory.Game.Short #5551

Closed
wants to merge 13 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator


Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Ruben-VandeVelde Ruben-VandeVelde added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Jun 28, 2023
@Ruben-VandeVelde Ruben-VandeVelde marked this pull request as ready for review June 28, 2023 19:15
@timotree3
Copy link
Collaborator

timotree3 commented Jul 1, 2023

I got this compiling in my fork: port/SetTheory.Game.Short...timotree3:mathlib4:port/SetTheory.Game.Short. I'm waiting for push permissions to update this PR

@timotree3 timotree3 added awaiting-CI and removed help-wanted The author needs attention to resolve issues labels Jul 1, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 1, 2023
bors bot pushed a commit that referenced this pull request Jul 1, 2023
Co-authored-by: timotree3 <timorcb@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Jul 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port SetTheory.Game.Short [Merged by Bors] - feat: port SetTheory.Game.Short Jul 1, 2023
@bors bors bot closed this Jul 1, 2023
@bors bors bot deleted the port/SetTheory.Game.Short branch July 1, 2023 19:52
bors bot pushed a commit that referenced this pull request Jul 2, 2023
- Fix capitalization of identifiers
- Add details to a porting note that I was investigating while Parcly-Taxel fixed #5551
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
Co-authored-by: timotree3 <timorcb@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
- Fix capitalization of identifiers
- Add details to a porting note that I was investigating while Parcly-Taxel fixed #5551
semorrison pushed a commit that referenced this pull request Aug 14, 2023
Co-authored-by: timotree3 <timorcb@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
semorrison pushed a commit that referenced this pull request Aug 14, 2023
- Fix capitalization of identifiers
- Add details to a porting note that I was investigating while Parcly-Taxel fixed #5551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants