Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: have tauto use Lean.Meta.isProp rather than Lean.Expr.isProp #5565

Closed
wants to merge 4 commits into from

Conversation

kmill
Copy link
Contributor

@kmill kmill commented Jun 29, 2023

Lean.Expr.isProp can't handle metavariables but Lean.Meta.isProp can.

Bug reported by @negiizhao


Open in Gitpod

@kmill kmill added awaiting-review t-meta Tactics, attributes or user commands labels Jun 29, 2023
@kmill kmill changed the title fix: have tauto instantiate metavariables fix: have tauto use Lean.Meta.isProp rather than Lean.Expr.isProp Jun 29, 2023
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 29, 2023
bors bot pushed a commit that referenced this pull request Jun 29, 2023
…p` (#5565)

`Lean.Expr.isProp` can't handle metavariables but `Lean.Meta.isProp` can.

Bug reported by @negiizhao
@bors
Copy link

bors bot commented Jun 29, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix: have tauto use Lean.Meta.isProp rather than Lean.Expr.isProp [Merged by Bors] - fix: have tauto use Lean.Meta.isProp rather than Lean.Expr.isProp Jun 29, 2023
@bors bors bot closed this Jun 29, 2023
@bors bors bot deleted the kmill_fix_tauto branch June 29, 2023 13:10
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
…p` (#5565)

`Lean.Expr.isProp` can't handle metavariables but `Lean.Meta.isProp` can.

Bug reported by @negiizhao
semorrison pushed a commit that referenced this pull request Aug 14, 2023
…p` (#5565)

`Lean.Expr.isProp` can't handle metavariables but `Lean.Meta.isProp` can.

Bug reported by @negiizhao
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants