Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Geometry.Manifold.Instances.Sphere #5571

Closed
wants to merge 32 commits into from
Closed

[Merged by Bors] - feat: port Geometry.Manifold.Instances.Sphere #5571

wants to merge 32 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 29, 2023

Open in Gitpod

@urkud urkud added the WIP Work in progress label Jun 29, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 30, 2023
@jcommelin jcommelin added the mathlib-port This is a port of a theory file from mathlib. label Jul 3, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jul 13, 2023
@mattrobball mattrobball added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jul 14, 2023
@urkud
Copy link
Member Author

urkud commented Jul 14, 2023

@mattrobball If you're going to fix this file "as is", then feel free to drop the new file about stereographic projection. I have a copy elsewhere.

@mattrobball mattrobball added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Jul 15, 2023
@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 15, 2023
bors bot pushed a commit that referenced this pull request Jul 15, 2023
@urkud @mattrobball @hrmacbeth
feat: port Geometry.Manifold.Instances.Sphere (#5571)
cd8b72b 
Co-authored-by: Matthew Ballard <matt@mrb.email>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 15, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Geometry.Manifold.Instances.Sphere [Merged by Bors] - feat: port Geometry.Manifold.Instances.Sphere Jul 15, 2023
@bors bors bot closed this Jul 15, 2023
@bors bors bot deleted the port/Geometry.Manifold.Instances.Sphere branch July 15, 2023 23:20
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@urkud @mattrobball
@hrmacbeth @semorrison
feat: port Geometry.Manifold.Instances.Sphere (#5571)
fbba36b 
Co-authored-by: Matthew Ballard <matt@mrb.email>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@urkud @PatrickMassot @semorrison @jcommelin @mattrobball @hrmacbeth