Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port AlgebraicGeometry.Pullbacks #5583

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - feat: port AlgebraicGeometry.Pullbacks #5583

wants to merge 10 commits into from

Conversation

jjaassoonn
Copy link
Collaborator

Open in Gitpod

@jjaassoonn
feat: port AlgebraicGeometry.Pullbacks
7cd51b1
@jjaassoonn
Initial file copy from mathport
f50f73a
@jjaassoonn
automated fixes
80a2f76 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@jjaassoonn jjaassoonn added the mathlib-port This is a port of a theory file from mathlib. label Jun 29, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 29, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 29, 2023
@jjaassoonn jjaassoonn marked this pull request as ready for review June 29, 2023 18:20
@jjaassoonn jjaassoonn added awaiting-review The author would like community review of the PR awaiting-CI labels Jun 29, 2023
jcommelin
jcommelin approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 29, 2023
bors bot pushed a commit that referenced this pull request Jun 29, 2023
@jjaassoonn @Parcly-Taxel
feat: port AlgebraicGeometry.Pullbacks (#5583)
80d2e74 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Jun 29, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port AlgebraicGeometry.Pullbacks [Merged by Bors] - feat: port AlgebraicGeometry.Pullbacks Jun 29, 2023
@bors bors bot closed this Jun 29, 2023
@bors bors bot deleted the port/AlgebraicGeometry.Pullbacks branch June 29, 2023 18:49
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
@jjaassoonn @Parcly-Taxel @kbuzzard
feat: port AlgebraicGeometry.Pullbacks (#5583)
0a7e715 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@jjaassoonn @Parcly-Taxel @semorrison
feat: port AlgebraicGeometry.Pullbacks (#5583)
6ba5a8e 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jjaassoonn @jcommelin @semorrison @Parcly-Taxel