Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Algebra/Category/GroupCat/Abelian): prove AddCommGroupCat is AB5 #5597

Closed
wants to merge 39 commits into from

Conversation

Multramate
Copy link
Collaborator

@Multramate Multramate commented Jun 29, 2023

This work was done during the 2023 Copenhagen masterclass on formalisation of condensed mathematics. Numerous participants contributed.

Co-authored-by: Moritz Firsching moritz.firsching@gmail.com
Co-authored-by: Nikolas Kuhn nikolaskuhn@gmx.de
Co-authored-by: Amelia Livingston 101damnations@github.com


Open in Gitpod

@Multramate Multramate added the WIP Work in progress label Jun 29, 2023
@mo271 mo271 force-pushed the AB5 branch 2 times, most recently from d35ee70 to d6daef3 Compare June 30, 2023 13:59
Mathlib/Algebra/Category/GroupCat/EpiMono.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Category/GroupCat/Abelian.lean Outdated Show resolved Hide resolved
@TwoFX TwoFX added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 27, 2023
@Multramate Multramate added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 29, 2023
@TwoFX TwoFX added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 30, 2023
@Multramate Multramate added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 30, 2023
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 31, 2023
bors bot pushed a commit that referenced this pull request Jul 31, 2023
…#5597)

This work was done during the 2023 Copenhagen masterclass on formalisation of condensed mathematics. Numerous participants contributed.

Co-authored-by: Moritz Firsching <moritz.firsching@gmail.com>
Co-authored-by: Nikolas Kuhn <nikolaskuhn@gmx.de>
Co-authored-by: Amelia Livingston <101damnations@github.com>



Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: adamtopaz <github@adamtopaz.com>
Co-authored-by: nick-kuhn <nikolaskuhn@gmx.de>
@bors
Copy link

bors bot commented Jul 31, 2023

Build failed:

@TwoFX
Copy link
Member

TwoFX commented Jul 31, 2023

bors r-

@TwoFX
Copy link
Member

TwoFX commented Jul 31, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jul 31, 2023
…#5597)

This work was done during the 2023 Copenhagen masterclass on formalisation of condensed mathematics. Numerous participants contributed.

Co-authored-by: Moritz Firsching <moritz.firsching@gmail.com>
Co-authored-by: Nikolas Kuhn <nikolaskuhn@gmx.de>
Co-authored-by: Amelia Livingston <101damnations@github.com>



Co-authored-by: Markus Himmel <markus@himmel-villmar.de>
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: adamtopaz <github@adamtopaz.com>
Co-authored-by: nick-kuhn <nikolaskuhn@gmx.de>
@bors
Copy link

bors bot commented Jul 31, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(Algebra/Category/GroupCat/Abelian): prove AddCommGroupCat is AB5 [Merged by Bors] - feat(Algebra/Category/GroupCat/Abelian): prove AddCommGroupCat is AB5 Jul 31, 2023
@bors bors bot closed this Jul 31, 2023
@bors bors bot deleted the AB5 branch July 31, 2023 10:24
semorrison pushed a commit that referenced this pull request Aug 2, 2023
…#5597)

This work was done during the 2023 Copenhagen masterclass on formalisation of condensed mathematics. Numerous participants contributed.

Co-authored-by: Moritz Firsching <moritz.firsching@gmail.com>
Co-authored-by: Nikolas Kuhn <nikolaskuhn@gmx.de>
Co-authored-by: Amelia Livingston <101damnations@github.com>



Co-authored-by: Markus Himmel <markus@himmel-villmar.de>
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: adamtopaz <github@adamtopaz.com>
Co-authored-by: nick-kuhn <nikolaskuhn@gmx.de>
semorrison pushed a commit that referenced this pull request Aug 14, 2023
…#5597)

This work was done during the 2023 Copenhagen masterclass on formalisation of condensed mathematics. Numerous participants contributed.

Co-authored-by: Moritz Firsching <moritz.firsching@gmail.com>
Co-authored-by: Nikolas Kuhn <nikolaskuhn@gmx.de>
Co-authored-by: Amelia Livingston <101damnations@github.com>



Co-authored-by: Markus Himmel <markus@himmel-villmar.de>
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: adamtopaz <github@adamtopaz.com>
Co-authored-by: nick-kuhn <nikolaskuhn@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Add features not present in Mathlib 3 ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc) t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants