Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port AlgebraicGeometry.Morphisms.Basic #5599

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: port AlgebraicGeometry.Morphisms.Basic #5599

wants to merge 11 commits into from

Conversation

jjaassoonn
Copy link
Collaborator

Open in Gitpod

@jjaassoonn
feat: port AlgebraicGeometry.Morphisms.Basic
6e32edb
@jjaassoonn
Initial file copy from mathport
c70247e
@jjaassoonn
automated fixes
9ad4ace 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@jjaassoonn jjaassoonn added the mathlib-port This is a port of a theory file from mathlib. label Jun 29, 2023
@jjaassoonn jjaassoonn marked this pull request as ready for review June 30, 2023 11:52
@jjaassoonn jjaassoonn added awaiting-review The author would like community review of the PR awaiting-CI labels Jun 30, 2023
jcommelin
jcommelin reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Mathlib/AlgebraicGeometry/Morphisms/Basic.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jun 30, 2023

✌️ jjaassoonn can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jun 30, 2023
@Parcly-Taxel @jcommelin
Update Mathlib/AlgebraicGeometry/Morphisms/Basic.lean
a145d9e 
Co-authored-by: Johan Commelin <johan@commelin.net>
@jjaassoonn
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jun 30, 2023
@jjaassoonn @Parcly-Taxel
feat: port AlgebraicGeometry.Morphisms.Basic (#5599)
f68e3bd 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Jun 30, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port AlgebraicGeometry.Morphisms.Basic [Merged by Bors] - feat: port AlgebraicGeometry.Morphisms.Basic Jun 30, 2023
@bors bors bot closed this Jun 30, 2023
@bors bors bot deleted the port/AlgebraicGeometry.Morphisms.Basic branch June 30, 2023 18:41
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
@jjaassoonn @Parcly-Taxel @kbuzzard
feat: port AlgebraicGeometry.Morphisms.Basic (#5599)
5164036 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@jjaassoonn @Parcly-Taxel @semorrison
feat: port AlgebraicGeometry.Morphisms.Basic (#5599)
7ef64ac 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jjaassoonn @jcommelin @semorrison @Parcly-Taxel