Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port LinearAlgebra.CliffordAlgebra.EvenEquiv #5600

Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - feat: port LinearAlgebra.CliffordAlgebra.EvenEquiv #5600

wants to merge 14 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde
feat: port LinearAlgebra.CliffordAlgebra.EvenEquiv
d7db4c4
@Ruben-VandeVelde
Initial file copy from mathport
6dd7280
@Ruben-VandeVelde
automated fixes
796594e 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Ruben-VandeVelde Ruben-VandeVelde added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 29, 2023
@Ruben-VandeVelde Ruben-VandeVelde marked this pull request as ready for review June 29, 2023 19:43
@Ruben-VandeVelde Ruben-VandeVelde added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jun 29, 2023
@eric-wieser eric-wieser self-assigned this Jul 7, 2023
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Jul 8, 2023
@eric-wieser eric-wieser removed their assignment Jul 8, 2023
jcommelin
jcommelin approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 8, 2023
bors bot pushed a commit that referenced this pull request Jul 8, 2023
@Ruben-VandeVelde @semorrison
@kbuzzard @eric-wieser
feat: port LinearAlgebra.CliffordAlgebra.EvenEquiv (#5600)
508cf50 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Jul 8, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port LinearAlgebra.CliffordAlgebra.EvenEquiv [Merged by Bors] - feat: port LinearAlgebra.CliffordAlgebra.EvenEquiv Jul 8, 2023
@bors bors bot closed this Jul 8, 2023
@bors bors bot deleted the port/LinearAlgebra.CliffordAlgebra.EvenEquiv branch July 8, 2023 10:08
semorrison added a commit that referenced this pull request Aug 14, 2023
@Ruben-VandeVelde @semorrison
@kbuzzard @eric-wieser
feat: port LinearAlgebra.CliffordAlgebra.EvenEquiv (#5600)
3812bca 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ruben-VandeVelde @jcommelin @eric-wieser @semorrison @kbuzzard