Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor: make pp_with_univ be an attribute #5633

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - refactor: make pp_with_univ be an attribute #5633

wants to merge 5 commits into from

Conversation

kmill
Copy link
Contributor

@kmill kmill commented Jun 30, 2023

Open in Gitpod

@kmill kmill added awaiting-review The author would like community review of the PR t-meta Tactics, attributes or user commands labels Jun 30, 2023
@kmill
Copy link
Contributor Author

kmill commented Jun 30, 2023

@gebner Here's the pp_with_univ PR

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jul 6, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jul 6, 2023
@fpvandoorn
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 6, 2023
bors bot pushed a commit that referenced this pull request Jul 6, 2023
@kmill
refactor: make pp_with_univ be an attribute (#5633)
99ec98e
@bors
Copy link

bors bot commented Jul 6, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title refactor: make pp_with_univ be an attribute [Merged by Bors] - refactor: make pp_with_univ be an attribute Jul 6, 2023
@bors bors bot closed this Jul 6, 2023
@bors bors bot deleted the kmill_pp_with_univ_attr branch July 6, 2023 15:46
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jul 7, 2023
@kmill @qawbecrdtey
refactor: make pp_with_univ be an attribute (leanprover-community#5633
f3d17f2 
)
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@kmill @semorrison
refactor: make pp_with_univ be an attribute (#5633)
df79daf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmill @fpvandoorn @semorrison