-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: drop an unneeded field of StarOrderedRing
#5639
Conversation
In `StarOrderedRing.ofLeIff`, the assumption `h_add : ∀ {x y}, x ≤ y → ∀ z, z + x ≤ z + y` follows from the other one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for removing this hypothesis.
maintainer merge
I have edited this PR now and it needs another reviewer. Sorry!
🚀 Pull request has been placed on the maintainer queue by j-loreaux. |
1 similar comment
🚀 Pull request has been placed on the maintainer queue by j-loreaux. |
actually, please wait on this, I realized that this means |
StarOrderedRing
Very nice, thanks! bors r+ |
In `StarOrderedRing.ofLeIff`, the assumption `h_add : ∀ {x y}, x ≤ y → ∀ z, z + x ≤ z + y` follows from the other one. Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
StarOrderedRing
StarOrderedRing
In `StarOrderedRing.ofLeIff`, the assumption `h_add : ∀ {x y}, x ≤ y → ∀ z, z + x ≤ z + y` follows from the other one. Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
In `StarOrderedRing.ofLeIff`, the assumption `h_add : ∀ {x y}, x ≤ y → ∀ z, z + x ≤ z + y` follows from the other one. Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
In
StarOrderedRing.ofLeIff
, the assumptionh_add : ∀ {x y}, x ≤ y → ∀ z, z + x ≤ z + y
follows from the other one.