Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: golf FunctionsBoundedAtInfty #5661

Closed
wants to merge 1 commit into from
Closed

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 2, 2023

Use lemmas about Filter.HasBasis to golf some proofs.


Open in Gitpod

Use lemmas about `Filter.HasBasis` to golf some proofs.
@urkud urkud added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jul 2, 2023
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

apply lt_of_le_of_lt (hA z hz)
linarith
apply hzs
IsZeroAtImInfty f ↔ ∀ ε : ℝ, 0 < ε → ∃ A : ℝ, ∀ z : ℍ, A ≤ im z → abs (f z) ≤ ε :=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

Suggested change
IsZeroAtImInfty f ↔ ∀ ε : ℝ, 0 < ε → ∃ A : ℝ, ∀ z : ℍ, A ≤ im z → abs (f z) ≤ ε :=
IsZeroAtImInfty f ↔ ∀ ε > 0, ∃ A : ℝ, ∀ z : ℍ, A ≤ im z → abs (f z) ≤ ε :=

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to change the statement now (even up to a reducible definition).

@bors
Copy link

bors bot commented Jul 2, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jul 2, 2023
@urkud
Copy link
Member Author

urkud commented Jul 2, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 2, 2023
bors bot pushed a commit that referenced this pull request Jul 2, 2023
Use lemmas about `Filter.HasBasis` to golf some proofs.
@bors
Copy link

bors bot commented Jul 2, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: golf FunctionsBoundedAtInfty [Merged by Bors] - chore: golf FunctionsBoundedAtInfty Jul 2, 2023
@bors bors bot closed this Jul 2, 2023
@bors bors bot deleted the YK-golf branch July 2, 2023 13:59
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
Use lemmas about `Filter.HasBasis` to golf some proofs.
semorrison pushed a commit that referenced this pull request Aug 14, 2023
Use lemmas about `Filter.HasBasis` to golf some proofs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants