[Merged by Bors] - chore: scope notations from category theory. #5685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickMassot
added
awaiting-review
|
Could you do the same for the notations in |
|
Good point, I'll work on this. |
|
The functor notations are now also scoped. This required a bit more fixing in random files. |
jcommelin
reviewed
Jul 3, 2023
Comment on lines
-20
to
-21
| (Unfortunately the `⇒` arrow (`\functor`) is taken by core, | ||
| but in mathlib4 we should switch to this.) |
There was a problem hiding this comment.
I think we should keep this comment.
PatrickMassot
commented
Jul 3, 2023
semorrison
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
Make sure in particular one can import Mathlib.Tactic for teaching without getting category theory notations in scope. Note that only two files needed an extra open.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
kbuzzard
pushed a commit
that referenced
this pull request
Jul 6, 2023
Make sure in particular one can import Mathlib.Tactic for teaching without getting category theory notations in scope. Note that only two files needed an extra open.
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
Make sure in particular one can import Mathlib.Tactic for teaching without getting category theory notations in scope. Note that only two files needed an extra open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure in particular one can import Mathlib.Tactic for teaching without getting category theory notations in scope. Note that only two files needed an extra open.
See Zulip conversation.