Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port AlgebraicGeometry.Morphisms.QuasiSeparated #5691

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - feat: port AlgebraicGeometry.Morphisms.QuasiSeparated #5691

wants to merge 10 commits into from

Conversation

jjaassoonn
Copy link
Collaborator

Open in Gitpod

@jjaassoonn
feat: port AlgebraicGeometry.Morphisms.QuasiSeparated
5d3a5b4
@jjaassoonn
Initial file copy from mathport
5c11947
@jjaassoonn
automated fixes
9f788d6 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@jjaassoonn jjaassoonn added the mathlib-port This is a port of a theory file from mathlib. label Jul 3, 2023
@jjaassoonn jjaassoonn marked this pull request as ready for review July 4, 2023 13:19
@jjaassoonn jjaassoonn added the help-wanted The author needs attention to resolve issues label Jul 4, 2023
@jjaassoonn jjaassoonn added awaiting-review The author would like community review of the PR awaiting-CI and removed help-wanted The author needs attention to resolve issues labels Jul 4, 2023
jcommelin
jcommelin approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 4, 2023
bors bot pushed a commit that referenced this pull request Jul 4, 2023
@jjaassoonn
feat: port AlgebraicGeometry.Morphisms.QuasiSeparated (#5691)
fe31d4e
@bors
Copy link

bors bot commented Jul 4, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jul 4, 2023
@jjaassoonn
feat: port AlgebraicGeometry.Morphisms.QuasiSeparated (#5691)
a8624a7
@bors
Copy link

bors bot commented Jul 4, 2023

Build failed:

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

bors bot pushed a commit that referenced this pull request Jul 4, 2023
@jjaassoonn
feat: port AlgebraicGeometry.Morphisms.QuasiSeparated (#5691)
cc5d11f
@bors
Copy link

bors bot commented Jul 4, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port AlgebraicGeometry.Morphisms.QuasiSeparated [Merged by Bors] - feat: port AlgebraicGeometry.Morphisms.QuasiSeparated Jul 4, 2023
@bors bors bot closed this Jul 4, 2023
@bors bors bot deleted the port/AlgebraicGeometry.Morphisms.QuasiSeparated branch July 4, 2023 19:06
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
@jjaassoonn @kbuzzard
feat: port AlgebraicGeometry.Morphisms.QuasiSeparated (#5691)
fb7916c
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@jjaassoonn @semorrison
feat: port AlgebraicGeometry.Morphisms.QuasiSeparated (#5691)
38db53f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjaassoonn @jcommelin @semorrison