chore: fix focusing dots and semicolons #5699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a linter check to ensure that focusing dots are centred (·) and not isolated (mathport may sometimes produce examples of the second kind).
Parcly-Taxel
changed the title
semorrison
reviewed
Jul 4, 2023
semorrison
reviewed
Jul 4, 2023
jcommelin
reviewed
Jul 4, 2023
jcommelin
reviewed
Jul 4, 2023
Comment on lines
+496
to
+501
| hb (hx.symm ▸ ⟨y, mul_right_cancel₀ hp.1 <| by | ||
| rw [tsub_add_cancel_of_le (succ_le_of_lt hm0)] at hy | ||
| simp [hy, pow_add, mul_comm, mul_assoc, mul_left_comm]⟩) | ||
| finite_mul_aux hp ha hpx ⟨s, mul_right_cancel₀ hp.1 (by | ||
| rw [add_assoc, tsub_add_cancel_of_le (succ_le_of_lt hm0)] | ||
| simp_all [mul_comm, mul_assoc, mul_left_comm, pow_add])⟩ |
There was a problem hiding this comment.
Idem dito for this kind of reformatting and reflowing of proofs.
Ideally a diff that touches > 30 files will be completely automatically generated by a script that fixes the syntax. Then we can have high confidence that the diff does one and does it well.
semorrison
added
the
merge-conflict
bors bot
pushed a commit
that referenced
this pull request
Jul 4, 2023
This is the second half of the changes originally in #5699, removing all occurrences of `;` _after_ a space and implementing a linter rule to enforce it. In most cases this 2-character substring has a space after it, so the following command was run first: ``` find . -type f -name "*.lean" -exec sed -i -E 's/ ; /; /g' {} \; ``` The remaining cases were few enough in number that they were done manually.
kbuzzard
pushed a commit
that referenced
this pull request
Jul 6, 2023
This is the second half of the changes originally in #5699, removing all occurrences of `;` _after_ a space and implementing a linter rule to enforce it. In most cases this 2-character substring has a space after it, so the following command was run first: ``` find . -type f -name "*.lean" -exec sed -i -E 's/ ; /; /g' {} \; ``` The remaining cases were few enough in number that they were done manually.
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
This is the second half of the changes originally in #5699, removing all occurrences of `;` _after_ a space and implementing a linter rule to enforce it. In most cases this 2-character substring has a space after it, so the following command was run first: ``` find . -type f -name "*.lean" -exec sed -i -E 's/ ; /; /g' {} \; ``` The remaining cases were few enough in number that they were done manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds linter checks to ensure that
It also removes some redundant semicolons.