Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port CategoryTheory.Monoidal.Internal.Module #5725

Closed
wants to merge 10 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Jul 5, 2023


Open in Gitpod

mo271 added 4 commits July 5, 2023 07:24
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@mo271 mo271 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jul 5, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Jul 5, 2023

currently there are errors of the type

synthesized type class instance is not definitionally equal to expression inferred by typing rules, synthesized
  NonUnitalNonAssocSemiring.toAddCommMonoid
inferred
  AddCommGroup.toAddCommMonoid

.. and also many others.

I will stop working on this for right now

@mo271 mo271 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jul 5, 2023
@jjaassoonn jjaassoonn added awaiting-review The author would like community review of the PR awaiting-CI and removed help-wanted The author needs attention to resolve issues labels Jul 6, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 6, 2023
bors bot pushed a commit that referenced this pull request Jul 6, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com>
@bors
Copy link

bors bot commented Jul 6, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port CategoryTheory.Monoidal.Internal.Module [Merged by Bors] - feat: port CategoryTheory.Monoidal.Internal.Module Jul 6, 2023
@bors bors bot closed this Jul 6, 2023
@bors bors bot deleted the port/CategoryTheory.Monoidal.Internal.Module branch July 6, 2023 04:32
semorrison pushed a commit that referenced this pull request Jul 6, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com>
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com>
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jul 7, 2023
…ity#5725)

Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com>
semorrison pushed a commit that referenced this pull request Aug 14, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants