[Merged by Bors] - feat(NumberTheory.NumberField.Units): add torsion subgroup #5748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xroblot
changed the title
|
Please remember to add the label |
xroblot
added
the
t-number-theory
Closed
3 tasks
xroblot
added
awaiting-review
xroblot
added
WIP
riccardobrasca
approved these changes
Jul 29, 2023
As you suggested, I asked for some expert opinion on Zulip |
Vierkantor
reviewed
Jul 31, 2023
Vierkantor
added
awaiting-author
xroblot
added
awaiting-review
|
βοΈ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
We define the torsion subgroup of the units of a number field and prove some results about it, mostly: it is finite, cyclic and an unit is torsion iff its value is 1 at all infinite places. Some results linking to `rootsOfUnity` are also proved. This PR also includes a direct coercion from `(π K)Λ£` to `K` that is very convenient, although I am not sure it's done properly.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
semorrison
pushed a commit
that referenced
this pull request
Aug 3, 2023
We define the torsion subgroup of the units of a number field and prove some results about it, mostly: it is finite, cyclic and an unit is torsion iff its value is 1 at all infinite places. Some results linking to `rootsOfUnity` are also proved. This PR also includes a direct coercion from `(π K)Λ£` to `K` that is very convenient, although I am not sure it's done properly.
semorrison
pushed a commit
that referenced
this pull request
Aug 3, 2023
We define the torsion subgroup of the units of a number field and prove some results about it, mostly: it is finite, cyclic and an unit is torsion iff its value is 1 at all infinite places. Some results linking to `rootsOfUnity` are also proved. This PR also includes a direct coercion from `(π K)Λ£` to `K` that is very convenient, although I am not sure it's done properly.
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
We define the torsion subgroup of the units of a number field and prove some results about it, mostly: it is finite, cyclic and an unit is torsion iff its value is 1 at all infinite places. Some results linking to `rootsOfUnity` are also proved. This PR also includes a direct coercion from `(π K)Λ£` to `K` that is very convenient, although I am not sure it's done properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We define the torsion subgroup of the units of a number field and prove some results about it, mostly: it is finite, cyclic and
an unit is torsion iff its value is 1 at all infinite places. Some results linking to
rootsOfUnityare also proved.This PR also includes a direct coercion from
(π K)Λ£toKthat is very convenient, although I am not sure it's done properly.