Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: define the category of extremally disconnected compact Hausdorff spaces #5761

Closed
wants to merge 22 commits into from
Closed

[Merged by Bors] - feat: define the category of extremally disconnected compact Hausdorff spaces #5761

wants to merge 22 commits into from

Conversation

dagurtomas
Copy link
Collaborator

@dagurtomas dagurtomas commented Jul 7, 2023 •
edited by jcommelin

Co-authored-by: Adam Topaz topaz@ualberta.ca @adamtopaz
Basics of the category Stonean of extremally disconnected compact Hausdorff spaces. This work was done during the 2023 Copenhagen masterclass on formalisation of condensed mathematics. Numerous participants contributed.

Open in Gitpod

@dagurtomas dagurtomas added the awaiting-review The author would like community review of the PR label Jul 7, 2023
@dagurtomas dagurtomas requested a review from jcommelin July 7, 2023 15:20
@adamtopaz adamtopaz added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 7, 2023
@dagurtomas dagurtomas added awaiting-review The author would like community review of the PR awaiting-CI new-feature Add features not present in Mathlib 3 and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 9, 2023
@dagurtomas
Copy link
Collaborator Author

I've modified everything according to Adam's suggestions

@dagurtomas dagurtomas mentioned this pull request Jul 11, 2023
Closed
2 tasks
@dagurtomas dagurtomas added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 18, 2023
@jcommelin
Copy link
Member

Two comments, but apart from that, LGTM

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 20, 2023
@dagurtomas dagurtomas added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 24, 2023
@dagurtomas
Copy link
Collaborator Author

Two comments, but apart from that, LGTM

Done

@dagurtomas
Copy link
Collaborator Author

Hmm, CI canceled the check "Detect changes to header SHAs / Add annotations (pull_request)". What does that mean?

@RemyDegenne
Copy link
Contributor

That check broke following a change in the way we do those headers. Please merge master. That should fix it.

jcommelin
jcommelin approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 27, 2023
bors bot pushed a commit that referenced this pull request Jul 27, 2023
@dagurtomas
feat: define the category of extremally disconnected compact Hausdorf…
f62d8a1 
…f spaces (#5761)

Co-authored-by: Adam Topaz [topaz@ualberta.ca](mailto:topaz@ualberta.ca) @adamtopaz 
Basics of the category `Stonean` of extremally disconnected compact Hausdorff spaces. This work was done during the 2023 Copenhagen masterclass on formalisation of condensed mathematics. Numerous participants contributed.
@bors
Copy link

bors bot commented Jul 27, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: define the category of extremally disconnected compact Hausdorff spaces [Merged by Bors] - feat: define the category of extremally disconnected compact Hausdorff spaces Jul 27, 2023
@bors bors bot closed this Jul 27, 2023
@bors bors bot deleted the ExtrDisc branch July 27, 2023 21:19
adomani pushed a commit that referenced this pull request Jul 28, 2023
@dagurtomas @adomani
feat: define the category of extremally disconnected compact Hausdorf…
85c5c84 
…f spaces (#5761)

Co-authored-by: Adam Topaz [topaz@ualberta.ca](mailto:topaz@ualberta.ca) @adamtopaz 
Basics of the category `Stonean` of extremally disconnected compact Hausdorff spaces. This work was done during the 2023 Copenhagen masterclass on formalisation of condensed mathematics. Numerous participants contributed.
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@dagurtomas @semorrison
feat: define the category of extremally disconnected compact Hausdorf…
2231575 
…f spaces (#5761)

Co-authored-by: Adam Topaz [topaz@ualberta.ca](mailto:topaz@ualberta.ca) @adamtopaz 
Basics of the category `Stonean` of extremally disconnected compact Hausdorff spaces. This work was done during the 2023 Copenhagen masterclass on formalisation of condensed mathematics. Numerous participants contributed.
bors bot pushed a commit that referenced this pull request Aug 22, 2023
@dagurtomas @Multramate
feat: projectivity of Stonean in CompHaus (#5808)
093597d 
Co-authored-by: Filippo A E Nuccio [filippo.nuccio@univ-st-etienne.fr](mailto:filippo.nuccio@univ-st-etienne.fr)
Co-authored-by: Nikolas Kuhn [nikolaskuhn@gmx.de](mailto:nikolaskuhn@gmx.de)
Co-authored-by: Adam Topaz [topaz@ualberta.ca](mailto:topaz@ualberta.ca)

 -  [x] depends on: #5634 
 -  [x] depends on: #5761  

This work was done during the 2023 Copenhagen masterclass on formalisation of condensed mathematics. Numerous participants contributed.



Co-authored-by: David Kurniadi Angdinata <dka31@cantab.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

@adamtopaz adamtopaz adamtopaz left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
new-feature Add features not present in Mathlib 3 ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dagurtomas @jcommelin @RemyDegenne @semorrison @adamtopaz @leanprover-community-mathlib4-bot