Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Data/Nat/Digits): two lemmas #5778

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(Data/Nat/Digits): two lemmas #5778

wants to merge 5 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Jul 9, 2023

Open in Gitpod

@mo271 mo271 added awaiting-review The author would like community review of the PR awaiting-CI labels Jul 9, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Jul 9, 2023

This is useful when proving another version of Legendre's Theorem, for context see:

https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/padicValNat_factorial.3A.20another.20version.20of.20Legendre's.20theorem

alexjbest
alexjbest reviewed Jul 10, 2023
View reviewed changes
Mathlib/Data/Nat/Digits.lean Outdated Show resolved Hide resolved
Mathlib/Data/Nat/Digits.lean Show resolved Hide resolved
mo271 and others added 2 commits July 10, 2023 07:53
@mo271 @alexjbest
Update Mathlib/Data/Nat/Digits.lean
6276f44 
Co-authored-by: Alex J Best <alex.j.best@gmail.com>
@mo271
add mono attribute
02e239b
@alexjbest
Copy link
Member

Lgtm now thanks

maintainer merge

@mo271 mo271 mentioned this pull request Jul 11, 2023
Closed
4 tasks
@mo271 mo271 added the new-feature Add features not present in Mathlib 3 label Jul 12, 2023
@ocfnash
Copy link
Contributor

ocfnash commented Jul 18, 2023

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 18, 2023
bors bot pushed a commit that referenced this pull request Jul 18, 2023
@mo271
feat(Data/Nat/Digits): two lemmas (#5778)
69bb9bc 
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Jul 18, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(Data/Nat/Digits): two lemmas [Merged by Bors] - feat(Data/Nat/Digits): two lemmas Jul 18, 2023
@bors bors bot closed this Jul 18, 2023
@bors bors bot deleted the mo271/digit_lemmas branch July 18, 2023 13:11
bors bot pushed a commit that referenced this pull request Aug 12, 2023
@mo271
feat(NumberTheory/Padics/PadicVal): padicValNat_factorial' (#5803)
4fbcc51 
- [x] depends on: #5778
- [x] depends on: #5789 
- [x] depends on: #5802 
- [x] depends on: #6505


Co-authored-by: Moritz Firsching <firsching@google.com>
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@mo271 @semorrison
feat(Data/Nat/Digits): two lemmas (#5778)
8ff1104 
Co-authored-by: Moritz Firsching <firsching@google.com>
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@mo271 @semorrison
feat(NumberTheory/Padics/PadicVal): padicValNat_factorial' (#5803)
ed8d8f5 
- [x] depends on: #5778
- [x] depends on: #5789 
- [x] depends on: #5802 
- [x] depends on: #6505


Co-authored-by: Moritz Firsching <firsching@google.com>
semorrison pushed a commit that referenced this pull request Aug 15, 2023
@mo271 @semorrison
feat(NumberTheory/Padics/PadicVal): padicValNat_factorial' (#5803)
5159ca9 
- [x] depends on: #5778
- [x] depends on: #5789 
- [x] depends on: #5802 
- [x] depends on: #6505


Co-authored-by: Moritz Firsching <firsching@google.com>
semorrison pushed a commit that referenced this pull request Aug 15, 2023
@mo271 @semorrison
feat(NumberTheory/Padics/PadicVal): padicValNat_factorial' (#5803)
de93369 
- [x] depends on: #5778
- [x] depends on: #5789 
- [x] depends on: #5802 
- [x] depends on: #6505


Co-authored-by: Moritz Firsching <firsching@google.com>
semorrison pushed a commit that referenced this pull request Aug 17, 2023
@mo271 @semorrison
feat(NumberTheory/Padics/PadicVal): padicValNat_factorial' (#5803)
b5bf69e 
- [x] depends on: #5778
- [x] depends on: #5789 
- [x] depends on: #5802 
- [x] depends on: #6505


Co-authored-by: Moritz Firsching <firsching@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjbest alexjbest alexjbest left review comments

Assignees
No one assigned
Labels
new-feature Add features not present in Mathlib 3 ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mo271 @alexjbest @ocfnash