[Merged by Bors] - feat: port Data.Fintype.Array #5792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
eric-wieser
added
the
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
The dashboard says > port, but completely rewrite in terms of the new array However, the new `Array T` isn't finite like `array n T` was, so the rewrite amounts to just deleting everything in the file. Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
This was referenced Jul 11, 2023
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
The dashboard says > port, but completely rewrite in terms of the new array However, the new `Array T` isn't finite like `array n T` was, so the rewrite amounts to just deleting everything in the file. Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dashboard says
However, the new
Array Tisn't finite likearray n Twas, so the rewrite amounts to just deleting everything in the file.