[Merged by Bors] - feat: add SeparableSpace instances
#5801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
urkud
commented
Jul 11, 2023
urkud
commented
urkud
added
awaiting-review
ADedecker
reviewed
Jul 11, 2023
ADedecker
added
awaiting-author
urkud
added
awaiting-review
|
Thanks! |
|
🚀 Pull request has been placed on the maintainer queue by ADedecker. |
ocfnash
approved these changes
Jul 11, 2023
| @@ -116,6 +116,9 @@ theorem countable_univ [Countable α] : (univ : Set α).Countable := | |||
| to_countable univ | |||
| #align set.countable_univ Set.countable_univ | |||
|
|
|||
| theorem countable_univ_iff : (univ : Set α).Countable ↔ Countable α := | |||
There was a problem hiding this comment.
Suggested change
| theorem countable_univ_iff : (univ : Set α).Countable ↔ Countable α := | |
| @[simp] theorem countable_univ_iff : (univ : Set α).Countable ↔ Countable α := |
There was a problem hiding this comment.
I would prefer not to add @[simp] here, at least before the port is over.
bors merge
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
semorrison
added
delegated
and removed
awaiting-review
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
SeparableSpace instancesSeparableSpace instances
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.