Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: replace Fin.castIso and Fin.revPerm with Fin.cast and Fin.rev for the bump of Std #5847

Closed
wants to merge 15 commits into from

Conversation

Komyyy
Copy link
Collaborator

@Komyyy Komyyy commented Jul 13, 2023

Some theorems in Data.Fin.Basic are copied to Std at the recent commit in Std.
These are written using Fin.cast and Fin.rev, so declarations using Fin.castIso and Fin.revPerm in Mathlib should be rewritten.


Open in Gitpod

@Komyyy Komyyy added the WIP Work in progress label Jul 13, 2023
@Komyyy Komyyy changed the title chore: replace Fin.castIso and Fin.revPerm with Fin.cast and Fin.rev chore: replace Fin.castIso and Fin.revPerm with Fin.cast and Fin.rev for the bump of Std Jul 13, 2023
@Komyyy Komyyy removed the WIP Work in progress label Jul 13, 2023
@Komyyy Komyyy added awaiting-review The author would like community review of the PR awaiting-CI and removed after-port labels Jul 13, 2023
@Komyyy Komyyy mentioned this pull request Jul 14, 2023
@Ruben-VandeVelde
Copy link
Collaborator

Are these changes improvements?

@Komyyy
Copy link
Collaborator Author

Komyyy commented Jul 14, 2023

@Ruben-VandeVelde Recently, the definitions like Fin.cast & Fin.rev are moved to Std and the types of Fin.cast & Fin.rev changed from OrderIso & Equiv.Perm to functions both. To prevent confusions, Fin.cast & Fin.rev and these related theorems are rewritten to Fin.castIso and Fin.revPerm. So the current Mathlib has few theorems about Fin.cast & Fin.rev.
This PR rewrites the related theorems back to Fin.cast & Fin.rev.

@eric-wieser
Copy link
Member

I think this change is probably a good thing given that Std4 changed in the way it did, as the canonical form should usually be the lowest-common-denominator of all available bundlings.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jul 24, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jul 27, 2023
@Komyyy Komyyy added awaiting-CI and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Jul 30, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Aug 5, 2023
@Komyyy Komyyy added awaiting-CI and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Aug 13, 2023
@jcommelin
Copy link
Member

@semorrison Could you please take a look at this PR?

@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 12, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment (applies in several places). Otherwise LGTM

Thanks for this PR!

bors d+

Mathlib/AlgebraicTopology/DoldKan/Decomposition.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Sep 12, 2023

✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Komyyy Komyyy removed the awaiting-author A reviewer has asked the author a question or requested changes label Sep 16, 2023
@Komyyy
Copy link
Collaborator Author

Komyyy commented Sep 16, 2023

bors r+

bors bot pushed a commit that referenced this pull request Sep 16, 2023
…in.rev` for the bump of Std (#5847)

Some theorems in `Data.Fin.Basic` are copied to Std at the recent commit in Std.
These are written using `Fin.cast` and `Fin.rev`, so declarations using `Fin.castIso` and `Fin.revPerm` in Mathlib should be rewritten.



Co-authored-by: Pol'tta / Miyahara Kō <52843868+Komyyy@users.noreply.github.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Sep 16, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: replace Fin.castIso and Fin.revPerm with Fin.cast and Fin.rev for the bump of Std [Merged by Bors] - chore: replace Fin.castIso and Fin.revPerm with Fin.cast and Fin.rev for the bump of Std Sep 16, 2023
@bors bors bot closed this Sep 16, 2023
@bors bors bot deleted the Komyyy/Fin.castIso branch September 16, 2023 07:20
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
…in.rev` for the bump of Std (#5847)

Some theorems in `Data.Fin.Basic` are copied to Std at the recent commit in Std.
These are written using `Fin.cast` and `Fin.rev`, so declarations using `Fin.castIso` and `Fin.revPerm` in Mathlib should be rewritten.



Co-authored-by: Pol'tta / Miyahara Kō <52843868+Komyyy@users.noreply.github.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants