New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: replace Fin.castIso
and Fin.revPerm
with Fin.cast
and Fin.rev
for the bump of Std
#5847
Conversation
Fin.castIso
and Fin.revPerm
with Fin.cast
and Fin.rev
Fin.castIso
and Fin.revPerm
with Fin.cast
and Fin.rev
for the bump of Std
Are these changes improvements? |
@Ruben-VandeVelde Recently, the definitions like |
I think this change is probably a good thing given that Std4 changed in the way it did, as the canonical form should usually be the lowest-common-denominator of all available bundlings. |
@semorrison Could you please take a look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment (applies in several places). Otherwise LGTM
Thanks for this PR!
bors d+
✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
…in.rev` for the bump of Std (#5847) Some theorems in `Data.Fin.Basic` are copied to Std at the recent commit in Std. These are written using `Fin.cast` and `Fin.rev`, so declarations using `Fin.castIso` and `Fin.revPerm` in Mathlib should be rewritten. Co-authored-by: Pol'tta / Miyahara Kō <52843868+Komyyy@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net>
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Fin.castIso
and Fin.revPerm
with Fin.cast
and Fin.rev
for the bump of StdFin.castIso
and Fin.revPerm
with Fin.cast
and Fin.rev
for the bump of Std
…in.rev` for the bump of Std (#5847) Some theorems in `Data.Fin.Basic` are copied to Std at the recent commit in Std. These are written using `Fin.cast` and `Fin.rev`, so declarations using `Fin.castIso` and `Fin.revPerm` in Mathlib should be rewritten. Co-authored-by: Pol'tta / Miyahara Kō <52843868+Komyyy@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net>
Some theorems in
Data.Fin.Basic
are copied to Std at the recent commit in Std.These are written using
Fin.cast
andFin.rev
, so declarations usingFin.castIso
andFin.revPerm
in Mathlib should be rewritten.