Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: empty ports of the Data/Buffer/Parser files #5848

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - chore: empty ports of the Data/Buffer/Parser files #5848

wants to merge 8 commits into from

Conversation

semorrison
Copy link
Contributor

Open in Gitpod

@semorrison
feat: port Data.Buffer.Parser.Numeral
23b699a
@semorrison
Initial file copy from mathport
e615938
@semorrison
automated fixes
3572b33 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@semorrison
empty ports of the Data/Buffer files
92a94d4
@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI labels Jul 13, 2023
@jcommelin
Copy link
Member

The three porting headers do not all refer to the same commit hash. Is that on purpose?

@semorrison
Copy link
Contributor Author

The three porting headers do not all refer to the same commit hash. Is that on purpose?

Not sure how that happened. mathlib3 updated underneath me? Anyway, they are all the same now.

@semorrison @jcommelin
Update Mathlib/Data/Buffer/Parser/Numeral.lean
461d2eb 
Co-authored-by: Johan Commelin <johan@commelin.net>
@jcommelin
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Jul 13, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR awaiting-CI labels Jul 13, 2023
@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 13, 2023
bors bot pushed a commit that referenced this pull request Jul 13, 2023
@semorrison
chore: empty ports of the Data/Buffer/Parser files (#5848)
b41e763 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Jul 13, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: empty ports of the Data/Buffer/Parser files [Merged by Bors] - chore: empty ports of the Data/Buffer/Parser files Jul 13, 2023
@bors bors bot closed this Jul 13, 2023
@bors bors bot deleted the port/Data.Buffer.Parser.Numeral branch July 13, 2023 08:35
@Komyyy Komyyy mentioned this pull request Jul 13, 2023
Closed
bors bot pushed a commit that referenced this pull request Jul 13, 2023
@Komyyy
chore: empty port of the Data.Buffer.Parser in core (#5864)
4d8f5b5 
addition to #5848
semorrison added a commit that referenced this pull request Aug 14, 2023
@semorrison
chore: empty ports of the Data/Buffer/Parser files (#5848)
9570d7f 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@Komyyy @semorrison
chore: empty port of the Data.Buffer.Parser in core (#5864)
f5ac30d 
addition to #5848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@semorrison @jcommelin @fpvandoorn