[Merged by Bors] - feat(Topology/Order/LowerUpperTopology): Dual the lower topology #5873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't see how to deduce from I think I need some way of identifying |
mans0954
added
the
awaiting-review
2 tasks
leanprover-community-mathlib4-bot
added
the
merge-conflict
|
Sorry for not commenting earlier, I'll review tomorrow. |
leanprover-community-mathlib4-bot
removed
the
merge-conflict
Thanks very much - I appreciate I must have taken up a lot of people's time with my PRs. |
ADedecker
reviewed
Jul 21, 2023
ADedecker
added
awaiting-author
You shouldn't have to worry about that, your contributions are definitely welcome and your code is looking good, so time spent reviewing it is time well-spent! |
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
mans0954
added
awaiting-review
ADedecker
added
awaiting-author
mans0954
added
awaiting-review
ADedecker
reviewed
Jul 24, 2023
Comment on lines
492
to
494
| constructor | ||
| · apply UpperTopology.instLowerTopologyOrderDualInstTopologicalSpaceOrderDualPreorder | ||
| · apply LowerTopology.instUpperTopologyOrderDualInstTopologicalSpaceOrderDualPreorder |
There was a problem hiding this comment.
Suggested change
| constructor | |
| · apply UpperTopology.instLowerTopologyOrderDualInstTopologicalSpaceOrderDualPreorder | |
| · apply LowerTopology.instUpperTopologyOrderDualInstTopologicalSpaceOrderDualPreorder | |
| constructor <;> intro _ <;> infer_instance |
If that works. Same below
There was a problem hiding this comment.
Unfortunately
lemma UpperDual_iff_Lower [Preorder α] [TopologicalSpace α] :
UpperTopology αᵒᵈ ↔ LowerTopology α := by
constructor <;> intro _ <;> infer_instance
gives me
failed to synthesize instance
LowerTopology α
There was a problem hiding this comment.
Ah right because it doesn't know how to go backwards. Then let's keep the current proof. Could you just give an explicit name to the instances so that it looks better?
ADedecker
added
awaiting-author
ADedecker
added
awaiting-review
|
Thanks! maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by ADedecker. |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
Defines the upper topology, which is the dual of the lower topology on a preorder. Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com> Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
Defines the upper topology, which is the dual of the lower topology on a preorder. Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com> Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines the upper topology, which is the dual of the lower topology on a preorder.
As requested by @YaelDillies and @ADedecker .
I have put the lower and upper topologies in the same file. However, this may complicate the lean4 porting effort, so it may be better to keep the files separate whilst mathlib and mathlib4 are being kept in sync?