[Merged by Bors] - feat: Encodable and Countable instances for Π₀ i, α i and α →₀ β
#5875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
sgouezel
reviewed
Jul 15, 2023
Mathlib/Data/DFinsupp/Basic.lean
Outdated
| /-- Equivalence between all dependent finitely supported functions `f : Π₀ i, β i` and type type | ||
| of pairs `⟨s : Finset ι, f : ∀ i : s, {x : β i // x ≠ 0}⟩`. -/ | ||
| @[simps! apply_fst apply_snd_coe] | ||
| def equivSigmaFinsetFun : (Π₀ i, β i) ≃ Σ s : Finset ι, ∀ i : s, {x : β i // x ≠ 0} := |
There was a problem hiding this comment.
I am not sure about the naming convention here, but it feels strange that the word equiv comes first here while it comes last in the above definition.
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
semorrison
added
delegated
and removed
awaiting-review
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
urkud
commented
Jul 15, 2023
urkud
commented
Jul 15, 2023
|
bors merge |
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Encodable and Countable instances for Π₀ i, α i and α →₀ βEncodable and Countable instances for Π₀ i, α i and α →₀ β
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5776