Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Analysis.InnerProductSpace.OfNorm #5885

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: port Analysis.InnerProductSpace.OfNorm #5885

wants to merge 4 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

Open in Gitpod

@Parcly-Taxel
feat: port Analysis.InnerProductSpace.OfNorm
822c423
@Parcly-Taxel
Initial file copy from mathport
e356e53
@Parcly-Taxel
automated fixes
90e6ffe 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Parcly-Taxel
Fix errors
9e7d544
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. awaiting-CI labels Jul 14, 2023
jcommelin
jcommelin approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Jul 14, 2023

✌️ Parcly-Taxel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jul 14, 2023
@Parcly-Taxel
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jul 14, 2023
@Parcly-Taxel
feat: port Analysis.InnerProductSpace.OfNorm (#5885)
36eb651
@bors
Copy link

bors bot commented Jul 14, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Analysis.InnerProductSpace.OfNorm [Merged by Bors] - feat: port Analysis.InnerProductSpace.OfNorm Jul 14, 2023
@bors bors bot closed this Jul 14, 2023
@bors bors bot deleted the port/Analysis.InnerProductSpace.OfNorm branch July 14, 2023 07:45
kbuzzard pushed a commit that referenced this pull request Jul 15, 2023
@Parcly-Taxel @kbuzzard
feat: port Analysis.InnerProductSpace.OfNorm (#5885)
12305de
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@Parcly-Taxel @semorrison
feat: port Analysis.InnerProductSpace.OfNorm (#5885)
a2fecf3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Parcly-Taxel @jcommelin @semorrison