Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#19234 #5887

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#19234 #5887

wants to merge 4 commits into from

Conversation

eric-wieser
Copy link
Member

Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged awaiting-CI labels Jul 14, 2023
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 16, 2023
bors bot pushed a commit that referenced this pull request Jul 16, 2023
@eric-wieser
chore: forward-port leanprover-community/mathlib#19234 (#5887)
d9991ff
@bors
Copy link

bors bot commented Jul 16, 2023

Build failed:

@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes awaiting-CI and removed ready-to-merge This PR has been sent to bors. labels Jul 16, 2023
@semorrison
Copy link
Contributor

Can't see anything but a transient SSL error during the bors build here, so I'm merging master to get a fresh CI.

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 16, 2023
@eric-wieser
Copy link
Member Author

bors merge

(CI is green, I assume that's the only reason this was awaiting author)

@bors
Copy link

bors bot commented Jul 16, 2023

Already running a review

@eric-wieser eric-wieser reopened this Jul 16, 2023
@eric-wieser
Copy link
Member Author

Whoops, misclick

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 16, 2023
bors bot pushed a commit that referenced this pull request Jul 16, 2023
@eric-wieser @semorrison
chore: forward-port leanprover-community/mathlib#19234 (#5887)
48029e8 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Jul 16, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: forward-port leanprover-community/mathlib#19234 [Merged by Bors] - chore: forward-port leanprover-community/mathlib#19234 Jul 16, 2023
@bors bors bot closed this Jul 16, 2023
@bors bors bot deleted the forward-port-19235 branch July 16, 2023 14:44
semorrison added a commit that referenced this pull request Aug 14, 2023
@eric-wieser @semorrison
chore: forward-port leanprover-community/mathlib#19234 (#5887)
3cb6e46 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eric-wieser @semorrison