-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: product instances for OrderedSub
#5890
Conversation
semorrison
commented
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surely these instances could go in Mathlib.Algebra.Order.Sub.Basic
?
I'm generally in favour of smaller files but in this case the granularity seems a bit too fine. I note that though you import Sub.Canonical
, in fact Sub.Basic
suffices.
In any case, I'll let you decide.
bors d+
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
Unfortunately in |
bors merge |
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
OrderedSub
OrderedSub
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>