Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: product instances for OrderedSub #5890

Closed
wants to merge 5 commits into from

Conversation

semorrison
Copy link
Contributor


Open in Gitpod

Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely these instances could go in Mathlib.Algebra.Order.Sub.Basic?

I'm generally in favour of smaller files but in this case the granularity seems a bit too fine. I note that though you import Sub.Canonical, in fact Sub.Basic suffices.

In any case, I'll let you decide.

bors d+

@bors
Copy link

bors bot commented Jul 18, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison
Copy link
Contributor Author

Surely these instances could go in Mathlib.Algebra.Order.Sub.Basic?

I'm generally in favour of smaller files but in this case the granularity seems a bit too fine. I note that though you import Sub.Canonical, in fact Sub.Basic suffices.

In any case, I'll let you decide.

bors d+

Unfortunately in Sub.Basic we fail with: error: failed to synthesize instance Add (α × β)

@semorrison
Copy link
Contributor Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 19, 2023
bors bot pushed a commit that referenced this pull request Jul 19, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Jul 19, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: product instances for OrderedSub [Merged by Bors] - feat: product instances for OrderedSub Jul 19, 2023
@bors bors bot closed this Jul 19, 2023
@bors bors bot deleted the tsub_lemmas branch July 19, 2023 04:14
semorrison added a commit that referenced this pull request Aug 14, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants