New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: Forward-port leanprover-community/mathlib#19230 #5907
Conversation
Thanks! 🎉 |
bors r- @YaelDillies, I'm confused by this claim. If you look at the file in its current state, it mentions |
Canceled. |
@semorrison, can you explain more? The history for the mathlib4 file contains no PR that claims to forward-port leanprover-community/mathlib#19153, so I am confusion. |
I suspect it was forward-ported while the file was still in progress |
We should either:
Probably only Scott can say which of these is correct |
These file have already diverged from mathlib3 due to the UnivLE experiments. Any discrepancies are mathlib3's problem, at this point. :-) |
We tried to forward port 19153, failed, and so reverted it back in mathlib3. Instead we've introduced the |
So should this file appear on out-of-sync, yes or no? Scott, as the author of the mathlib changes, this is your responsability. |
I'll make a SHA only PR now. |
This is already a SHA only PR... I don't understand why the bors merge was cancelled in the first place. bors merge |
This forward-ports the revert (leanprover-community/mathlib#19230) of changes that were never forward-ported (leanprover-community/mathlib#19153). Therefore only the SHA needs updating.
Canceled. |
bors merge I don't know why we didn't just forward-port the diff here... |
This doesn't forward-port the removal of `.{u}` as this doesn't actually change the type, and just results in `.{u_1}` being implied instead. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This PR was included in a batch that was canceled, it will be automatically retried |
This doesn't forward-port the removal of `.{u}` as this doesn't actually change the type, and just results in `.{u_1}` being implied instead. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This doesn't forward-port the removal of `.{u}` as this doesn't actually change the type, and just results in `.{u_1}` being implied instead. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This doesn't forward-port the removal of
.{u}
as this doesn't actually change the type, and just results in.{u_1}
being implied instead.This forward-ports the revert (leanprover-community/mathlib#19230) of changes that were never forward-ported (leanprover-community/mathlib#19153). Therefore only the SHA needs updating.