Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Data/Nat/EvenOddRec): add strong recursion principle on even and odd numbers #5932

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(Data/Nat/EvenOddRec): add strong recursion principle on even and odd numbers #5932

wants to merge 4 commits into from

Conversation

Multramate
Copy link
Collaborator

Open in Gitpod

@Multramate Multramate added awaiting-review The author would like community review of the PR awaiting-CI new-feature Add features not present in Mathlib 3 labels Jul 15, 2023
@ocfnash ocfnash added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 21, 2023
@Multramate Multramate added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 21, 2023
@Multramate Multramate added the help-wanted The author needs attention to resolve issues label Jul 21, 2023
@bors bors bot changed the base branch from master to ScottCarnahan/BinomialRing2 September 17, 2023 03:24
@semorrison semorrison changed the base branch from ScottCarnahan/BinomialRing2 to master September 17, 2023 12:16
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 10, 2024
@Multramate Multramate added awaiting-CI and removed help-wanted The author needs attention to resolve issues merge-conflict The PR has a merge conflict with master, and needs manual merging. new-feature Add features not present in Mathlib 3 labels Feb 20, 2024
ocfnash
ocfnash approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please apply the suggestions and then feel free to merge.

bors d+

Mathlib/Data/Nat/EvenOddRec.lean Outdated Show resolved Hide resolved
Mathlib/Data/Nat/EvenOddRec.lean Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 20, 2024

✌️ Multramate can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 20, 2024
@Multramate @ocfnash
Golf
f6ca18a 
Co-authored-by: Oliver Nash <github@olivernash.org>
@Multramate
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 20, 2024
@Multramate
feat(Data/Nat/EvenOddRec): add strong recursion principle on even and…
6f4fbe6 
… odd numbers (#5932)
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Nat/EvenOddRec): add strong recursion principle on even and odd numbers [Merged by Bors] - feat(Data/Nat/EvenOddRec): add strong recursion principle on even and odd numbers Feb 20, 2024
@mathlib-bors mathlib-bors bot closed this Feb 20, 2024
@mathlib-bors mathlib-bors bot deleted the Nat.evenOddStrongRec branch February 20, 2024 19:12
thorimur pushed a commit that referenced this pull request Feb 24, 2024
@Multramate @thorimur
feat(Data/Nat/EvenOddRec): add strong recursion principle on even and…
6c02ef0 
… odd numbers (#5932)
thorimur pushed a commit that referenced this pull request Feb 26, 2024
@Multramate @thorimur
feat(Data/Nat/EvenOddRec): add strong recursion principle on even and…
fb181d9 
… odd numbers (#5932)
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
@Multramate @riccardobrasca
feat(Data/Nat/EvenOddRec): add strong recursion principle on even and…
82c402a 
… odd numbers (#5932)
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@Multramate @dagurtomas
feat(Data/Nat/EvenOddRec): add strong recursion principle on even and…
843adcc 
… odd numbers (#5932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocfnash ocfnash ocfnash approved these changes

Assignees
No one assigned
Labels
delegated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Multramate @ocfnash @leanprover-community-mathlib4-bot