feat: port Data.Rat.MetaDefs #5934
Open
+183
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
eric-wieser
added
WIP
eric-wieser
added
t-meta
eric-wieser
commented
Jul 15, 2023
| /-- `Int.toExprQ α _ z _` embeds `q` as a numeral expression inside a type with `OfNat` and `-`. | ||
| -/ | ||
| def Int.toExprQ {u : Lean.Level} (α : Q(Type u)) (_ : Q(Neg $α)) (z : ℤ) | ||
| (_ : let zna := z.natAbs; by exact Q(OfNat $α $zna)) : Q($α) := |
There was a problem hiding this comment.
@gebner, is there syntax along the lines of Q(OfNat $α $(z.natAbs))? It doesn't seem to work here.
There was a problem hiding this comment.
No, the antiquotations are assumed to be of type Q(_). Longer-term, it would probably be best to explicitly write toExprQ z.natAbs (bikeshed) here.
There was a problem hiding this comment.
Oh, I didn't know about toExprQ (I assume it already exists?)
bors
bot
changed the base branch from
master
to
ScottCarnahan/BinomialRing2
semorrison
changed the base branch from
ScottCarnahan/BinomialRing2
to
master
leanprover-community-mathlib4-bot
added
the
merge-conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs some eyes from people familiar with Qq