[Merged by Bors] - feat: Add a DecidableEq instance for Polynomial
#5942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(mathlib does not compile anymore, because at some point, it needs to equate this axiom with the classically added one…) |
urkud
reviewed
Jul 22, 2023
AntoineChambert-Loir
added
awaiting-review
Ruben-VandeVelde
changed the title
DecidableEq instance for Polynomial
eric-wieser
reviewed
Jul 23, 2023
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
eric-wieser
reviewed
Aug 2, 2023
leanprover-community-mathlib4-bot
added
the
merge-conflict
eric-wieser
approved these changes
Aug 2, 2023
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
No one replied to
on Zulip, so bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
Add a `DecidableEq` instance for `Polynomial` (in the presence of `DecidableEq` for coefficients). This instance is the companion of an analogue instance for `MvPolynomial`, and it allows to use if… then… else for `Polynomial` without having to `open Classical`. This also makes `Polynomial.instNormalizationMonoid` computable, by defining it in terms of this new instance. Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@math.univ-paris-diderot.fr> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
DecidableEq instance for PolynomialDecidableEq instance for Polynomial
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
Add a `DecidableEq` instance for `Polynomial` (in the presence of `DecidableEq` for coefficients). This instance is the companion of an analogue instance for `MvPolynomial`, and it allows to use if… then… else for `Polynomial` without having to `open Classical`. This also makes `Polynomial.instNormalizationMonoid` computable, by defining it in terms of this new instance. Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@math.univ-paris-diderot.fr> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
semorrison
pushed a commit
that referenced
this pull request
Aug 15, 2023
Add a `DecidableEq` instance for `Polynomial` (in the presence of `DecidableEq` for coefficients). This instance is the companion of an analogue instance for `MvPolynomial`, and it allows to use if… then… else for `Polynomial` without having to `open Classical`. This also makes `Polynomial.instNormalizationMonoid` computable, by defining it in terms of this new instance. Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@math.univ-paris-diderot.fr> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
DecidableEqinstance forPolynomial(in the presence ofDecidableEqfor coefficients).This instance is the companion of an analogue instance for
MvPolynomial, and it allows to use if… then… else forPolynomialwithout having toopen Classical.This also makes
Polynomial.instNormalizationMonoidcomputable, by defining it in terms of this new instance.