Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor: split Analysis.Calculus.LocalExtr #5944

Closed
wants to merge 7 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 16, 2023

Also make f/f' arguments implicit in all versions of Rolle's Theorem.

Fixes #4830

API changes

  • exists_Ioo_extr_on_Icc:
    • generalize from functions f : ℝ → ℝ
      to functions from a conditionally complete linear order
      to a linear order.
    • make f implicit;
  • exists_local_extr_Ioo:
    • rename to exists_isLocalExtr_Ioo;
    • generalize as above;
    • make f implicit;
  • exists_isExtrOn_Ioo_of_tendsto, exists_isLocalExtr_Ioo_of_tendsto:
    new lemmas extracted from the proof of exists_hasDerivAt_eq_zero';
  • exists_hasDerivAt_eq_zero, exists_hasDerivAt_eq_zero':
    make f and f' implicit;
  • exists_deriv_eq_zero, exists_deriv_eq_zero':
    make f implicit.

Open in Gitpod

@urkud urkud added awaiting-review t-analysis Analysis (normed *, calculus) t-topology Topological spaces, uniform spaces, metric spaces, filters labels Jul 16, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jul 18, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jul 19, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jul 19, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jul 19, 2023
@ocfnash
Copy link
Contributor

ocfnash commented Jul 26, 2023

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 26, 2023
bors bot pushed a commit that referenced this pull request Jul 26, 2023
Also make `f`/`f'` arguments implicit in all versions of Rolle's Theorem.

Fixes #4830

## API changes

- `exists_Ioo_extr_on_Icc`:
  - generalize from functions `f : ℝ → ℝ`
    to functions from a conditionally complete linear order
    to a linear order.
  - make `f` implicit;
- `exists_local_extr_Ioo`:
  - rename to `exists_isLocalExtr_Ioo`;
  - generalize as above;
  - make `f` implicit;
- `exists_isExtrOn_Ioo_of_tendsto`, `exists_isLocalExtr_Ioo_of_tendsto`:
  new lemmas extracted from the proof of `exists_hasDerivAt_eq_zero'`;
- `exists_hasDerivAt_eq_zero`, `exists_hasDerivAt_eq_zero'`:
  make `f` and `f'` implicit;
- `exists_deriv_eq_zero`, `exists_deriv_eq_zero'`:
  make `f` implicit.
@bors
Copy link

bors bot commented Jul 26, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title refactor: split Analysis.Calculus.LocalExtr [Merged by Bors] - refactor: split Analysis.Calculus.LocalExtr Jul 26, 2023
@bors bors bot closed this Jul 26, 2023
@bors bors bot deleted the YK-split-local-extr branch July 26, 2023 11:43
semorrison pushed a commit that referenced this pull request Aug 14, 2023
Also make `f`/`f'` arguments implicit in all versions of Rolle's Theorem.

Fixes #4830

## API changes

- `exists_Ioo_extr_on_Icc`:
  - generalize from functions `f : ℝ → ℝ`
    to functions from a conditionally complete linear order
    to a linear order.
  - make `f` implicit;
- `exists_local_extr_Ioo`:
  - rename to `exists_isLocalExtr_Ioo`;
  - generalize as above;
  - make `f` implicit;
- `exists_isExtrOn_Ioo_of_tendsto`, `exists_isLocalExtr_Ioo_of_tendsto`:
  new lemmas extracted from the proof of `exists_hasDerivAt_eq_zero'`;
- `exists_hasDerivAt_eq_zero`, `exists_hasDerivAt_eq_zero'`:
  make `f` and `f'` implicit;
- `exists_deriv_eq_zero`, `exists_deriv_eq_zero'`:
  make `f` implicit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Analysis.Calculus.LocalExtr
4 participants