feat: add APIs about Quotient.choice
#5995
Open
+76
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gebner
reviewed
Jul 20, 2023
leanprover-community-mathlib4-bot
added
the
merge-conflict
bors
bot
changed the base branch from
master
to
ScottCarnahan/BinomialRing2
FR-vdash-bot
changed the base branch from
ScottCarnahan/BinomialRing2
to
master
leanprover-community-mathlib4-bot
removed
the
merge-conflict
YaelDillies
reviewed
Dec 12, 2023
There was a problem hiding this comment.
This looks reasonable, but I know there was some previous discussion involving @eric-wieser. What's the situation here?
| noncomputable def Quotient.choice {ι : Type*} {α : ι → Type*} [S : ∀ i, Setoid (α i)] | ||
| /-- Given a class of functions `q : @Quotient (∀ i, α i) _`, returns the class of `i`-th projection | ||
| `Quotient (S i)`. -/ | ||
| def Quotient.proj {ι : Sort*} {α : ι → Sort*} [S : ∀ i, Setoid (α i)] |
There was a problem hiding this comment.
Should that not be called something like Quotient.eval instead?
YaelDillies
added
awaiting-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some docs in this PR refer to the definition in #5576.