Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Topology.ProperMap): basic theory of proper maps #6005

Closed
wants to merge 18 commits into from

Conversation

ADedecker
Copy link
Member


Open in Gitpod

@ADedecker ADedecker added the WIP Work in progress label Jul 19, 2023
@ADedecker ADedecker added awaiting-review The author would like community review of the PR new-feature Add features not present in Mathlib 3 t-topology Topological spaces, uniform spaces, metric spaces, filters and removed WIP Work in progress labels Jul 23, 2023
@ADedecker ADedecker removed the new-feature Add features not present in Mathlib 3 label Jul 26, 2023
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

bors d+

Mathlib/Topology/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Topology/ContinuousOn.lean Outdated Show resolved Hide resolved
/-- A map `f : X → Y` is closed if and only if for all sets `s`, any cluster point of `f '' s` is
the image by `f` of some cluster point of `s`.
If you require this for all filters instead of just principal filters, and also that `f` is
continuous, you get the notion of **proper map**. See `isProperMap_iff_clusterPt`. -/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the first time in my life, I think I now understand what a proper map is.

Copy link
Member Author

@ADedecker ADedecker Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see that I'm not the only one to find this parallel very satisfying 😃

Mathlib/Topology/StoneCech.lean Outdated Show resolved Hide resolved
Mathlib/Topology/ProperMap.lean Outdated Show resolved Hide resolved
Mathlib/Topology/ProperMap.lean Outdated Show resolved Hide resolved
Mathlib/Topology/ProperMap.lean Outdated Show resolved Hide resolved
Mathlib/Topology/ProperMap.lean Outdated Show resolved Hide resolved
Mathlib/Topology/ProperMap.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 29, 2023

✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Jul 29, 2023
@ADedecker
Copy link
Member Author

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 31, 2023
@bors
Copy link

bors bot commented Jul 31, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(Topology.ProperMap): basic theory of proper maps [Merged by Bors] - feat(Topology.ProperMap): basic theory of proper maps Jul 31, 2023
@bors bors bot closed this Jul 31, 2023
@bors bors bot deleted the AD_proper_map branch July 31, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants