[Merged by Bors] - feat: restore field_simp [*] #6024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjbest
added
awaiting-review
|
I agree with your assessment, but this seems like a reasonable short-term solution and easy enough to swap out once we figure out what to do. Thanks! bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
fixes #5689 to do this we basically copy the missing functionality over from the simp internals
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
semorrison
pushed a commit
that referenced
this pull request
Aug 2, 2023
fixes #5689 to do this we basically copy the missing functionality over from the simp internals
semorrison
pushed a commit
that referenced
this pull request
Aug 2, 2023
fixes #5689 to do this we basically copy the missing functionality over from the simp internals
semorrison
pushed a commit
that referenced
this pull request
Aug 3, 2023
fixes #5689 to do this we basically copy the missing functionality over from the simp internals
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
fixes #5689 to do this we basically copy the missing functionality over from the simp internals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5689
to do this we basically copy the missing functionality over from the simp internals
To be honest the implementation of field simp seems a bit unwieldy to me right now, I'd be much happier to see it reimplemented as a macro or something closer to that if possible and reusing more of the original simp internals