-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(RepresentationTheory.GroupCohomology): make namespaces lower camel case #6029
Conversation
I am not sure that
(I am not sure what is the best justification for this, but it seems that lowercase initials in namespaces are used in order to develop the API around a definition which starts with a lowercase letter: for example, we have the definition of the object Ah, actually, in |
Thank you - yeah, I've changed namespaces to lower camel when there's a definition with that name. |
Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause |
Thanks! bors merge |
…mel case (#6029) Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Absolutely no idea why I thought these namespaces needed to be upper camel case.