Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(RepresentationTheory.GroupCohomology): make namespaces lower camel case #6029

Closed
wants to merge 7 commits into from

Conversation

101damnations
Copy link
Collaborator


Absolutely no idea why I thought these namespaces needed to be upper camel case.

Open in Gitpod

@101damnations 101damnations added the awaiting-review The author would like community review of the PR label Jul 20, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jul 28, 2023
@joelriou
Copy link
Collaborator

joelriou commented Sep 14, 2023

I am not sure that groupCohomology is better than GroupCohomology. For example, we have CategoryTheory, and not categoryTheory. Most namespaces in mathlib start with an uppercase letter:

joel@kalyani ~/lean/mathlib4 $ grep '^namespace [a-z]' **/*.lean|wc -l
130
joel@kalyani ~/lean/mathlib4 $ grep '^namespace [A-Z]' **/*.lean|wc -l
6761

(I am not sure what is the best justification for this, but it seems that lowercase initials in namespaces are used in order to develop the API around a definition which starts with a lowercase letter: for example, we have the definition of the object kernel f, and then we have kernel.lift.)

Ah, actually, in GroupCohomology.Basic, you define a term groupCohomology... Then, the namespace name change makes sense!

@bors bors bot changed the base branch from master to ScottCarnahan/BinomialRing2 September 17, 2023 03:24
@semorrison semorrison changed the base branch from ScottCarnahan/BinomialRing2 to master September 17, 2023 12:15
@101damnations 101damnations added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 11, 2023
@101damnations
Copy link
Collaborator Author

Thank you - yeah, I've changed namespaces to lower camel when there's a definition with that name.

@101damnations 101damnations added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 11, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Oct 11, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Oct 16, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Oct 18, 2023
@digama0
Copy link
Member

digama0 commented Oct 21, 2023

Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause lake clean to delete your mathlib folder! If you need to do so, make sure to delete lakefile.olean manually before running any lake commands.

@joelriou
Copy link
Collaborator

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 23, 2023
bors bot pushed a commit that referenced this pull request Oct 23, 2023
…mel case (#6029)

Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@bors
Copy link

bors bot commented Oct 23, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore(RepresentationTheory.GroupCohomology): make namespaces lower camel case [Merged by Bors] - chore(RepresentationTheory.GroupCohomology): make namespaces lower camel case Oct 23, 2023
@bors bors bot closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants